Skip to content

Hardcodes COSINE #16

Description

@gkennos

Is there an existing issue for this?

  • I have searched the existing issues

Bug summary

The graph-based grounding path in omop_graph.py:641 hardcodes metric_type=MetricType.COSINE regardless of what metric the registered model was actually indexed with.

If a model was indexed with L2, the graph grounding path would query with COSINE on potentially un-normalized vectors.

Code for reproduction

n/a

Error messages

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions