Skip to content

Implement NetworkBlock.AnnounceBlock on translation shim type. #4804

Description

@timwu20

Issue summary

from design doc:

AnnounceBlock method is used by GossipEngine to announce blocks before GRANDPA specific messages are sent. We already have functionality to create instances network.BlockAnnounceMessage using core.createBlockAnnounce that can be sent over the Network via Network.GossipMessage. We will need to replicate/make public the BlockAnnounceMessage constructor that also has the Network to send block announces.

Implementation details

  • Implement NetworkBlock.AnnounceBlock in translation shim typ utilizing existing core functionality.

Other information and links

Acceptance criteria

[] Calls to AnnounceBlock should gossip block announce to connected peers.
[] 70% unit test coverage on new AnnounceBlock functionality.

Metadata

Metadata

Assignees

No one assigned

    Labels

    T-implementationthis issue/pr is a new feature or functionality.

    Type

    No type

    Projects

    Status
    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions