Endpoint Tests

Author: mckaragoz

src/CodeBeam.UltimateAuth.Server/Endpoints/LogoutEndpointHandler.cs

@@ -19,17 +19,15 @@ public sealed class LogoutEndpointHandler : ILogoutEndpointHandler
     private readonly IUAuthFlowService _flow;
     private readonly IAccessContextFactory _accessContextFactory;
     private readonly ISessionApplicationService _sessionApplicationService;
-    private readonly IClock _clock;
     private readonly IUAuthCookieManager _cookieManager;
     private readonly IAuthRedirectResolver _redirectResolver;
 
-    public LogoutEndpointHandler(IAuthFlowContextAccessor authContext, IUAuthFlowService flow, IAccessContextFactory accessContextFactory, ISessionApplicationService sessionApplicationService, IClock clock, IUAuthCookieManager cookieManager, IAuthRedirectResolver redirectResolver)
+    public LogoutEndpointHandler(IAuthFlowContextAccessor authContext, IUAuthFlowService flow, IAccessContextFactory accessContextFactory, ISessionApplicationService sessionApplicationService, IUAuthCookieManager cookieManager, IAuthRedirectResolver redirectResolver)
     {
         _authContext = authContext;
         _flow = flow;
         _accessContextFactory = accessContextFactory;
         _sessionApplicationService = sessionApplicationService;
-        _clock = clock;
         _cookieManager = cookieManager;
         _redirectResolver = redirectResolver;
     }
@@ -151,7 +149,7 @@ public async Task<IResult> LogoutAllSelfAsync(HttpContext ctx)
             flow,
             UAuthActions.Flows.LogoutAllSelf,
             resource: "flows",
-            resourceId: userKey);
+            resourceId: userKey.Value);
 
         await _sessionApplicationService.LogoutAllDevicesAsync(access, userKey, ctx.RequestAborted);
         return Results.Ok();

src/CodeBeam.UltimateAuth.Server/Endpoints/PkceEndpointHandler.cs

@@ -163,6 +163,11 @@ public async Task<IResult> CompleteAsync(HttpContext ctx)
         if (request is null)
             return Results.BadRequest("Invalid PKCE payload.");
 
+        if (string.IsNullOrWhiteSpace(request.AuthorizationCode) || string.IsNullOrWhiteSpace(request.CodeVerifier))
+        {
+            return Results.BadRequest("authorization_code and code_verifier are required.");
+        }
+
         var result = await _pkceService.CompleteAsync(
             auth,
             new PkceCompleteRequest

src/CodeBeam.UltimateAuth.Server/Infrastructure/Redirect/RedirectDecision.cs

@@ -5,7 +5,7 @@ public sealed class RedirectDecision
     public bool Enabled { get; }
     public string? TargetUrl { get; }
 
-    private RedirectDecision(bool enabled, string? targetUrl)
+    internal RedirectDecision(bool enabled, string? targetUrl)
     {
         Enabled = enabled;
         TargetUrl = targetUrl;

tests/CodeBeam.UltimateAuth.Tests.Unit/Helpers/AuthFlowTestFactory.cs

@@ -11,47 +11,34 @@ namespace CodeBeam.UltimateAuth.Tests.Unit.Helpers;
 
 internal static class AuthFlowTestFactory
 {
-    public static AuthFlowContext LoginSuccess(ReturnUrlInfo? returnUrlInfo = null, EffectiveRedirectResponse? redirect = null)
-    {
-        return new AuthFlowContext(
-            flowType: AuthFlowType.Login,
-            clientProfile: UAuthClientProfile.BlazorServer,
-            effectiveMode: UAuthMode.PureOpaque,
-            device: TestDevice.Default(),
-            tenantKey: TenantKey.Single,
-            isAuthenticated: true,
-            userKey: UserKey.New(),
-            session: null,
-            originalOptions: TestServerOptions.Default(),
-            effectiveOptions: TestServerOptions.Effective(),
-            response: new EffectiveAuthResponse(
-                sessionIdDelivery: CredentialResponseOptions.Disabled(GrantKind.Session),
-                accessTokenDelivery: CredentialResponseOptions.Disabled(GrantKind.AccessToken),
-                refreshTokenDelivery: CredentialResponseOptions.Disabled(GrantKind.RefreshToken),
-                redirect: redirect ?? EffectiveRedirectResponse.Disabled
-            ),
-            primaryTokenKind: PrimaryTokenKind.Session,
-            returnUrlInfo: returnUrlInfo ?? ReturnUrlInfo.None()
-        );
-    }
+    public static AuthFlowContext LoginSuccess(
+        ReturnUrlInfo? returnUrlInfo = null,
+        EffectiveRedirectResponse? redirect = null)
+        => New(
+            returnUrlInfo: returnUrlInfo,
+            redirect: redirect);
 
     public static AuthFlowContext New(
         ReturnUrlInfo? returnUrlInfo = null,
         EffectiveRedirectResponse? redirect = null,
-        TenantKey? tenant = null)
+        TenantKey? tenant = null,
+        UserKey? userKey = null,
+        SessionSecurityContext? session = null,
+        bool isAuthenticated = true,
+        EffectiveAuthResponse? response = null)
     {
         return new AuthFlowContext(
             flowType: AuthFlowType.Login,
             clientProfile: UAuthClientProfile.BlazorServer,
             effectiveMode: UAuthMode.PureOpaque,
             device: TestDevice.Default(),
             tenantKey: tenant ?? TenantKey.Single,
-            isAuthenticated: true,
-            userKey: UserKey.New(),
-            session: null,
+            isAuthenticated: isAuthenticated,
+            userKey: userKey ?? (isAuthenticated ? UserKey.New() : null),
+            session: session,
             originalOptions: TestServerOptions.Default(),
             effectiveOptions: TestServerOptions.Effective(),
-            response: new EffectiveAuthResponse(
+            response: response ?? new EffectiveAuthResponse(
                 sessionIdDelivery:
                     CredentialResponseOptions.Disabled(GrantKind.Session),
                 accessTokenDelivery:

tests/CodeBeam.UltimateAuth.Tests.Unit/Helpers/TestAccessContext.cs

@@ -22,7 +22,12 @@ public static AccessContext WithAction(string action)
         );
     }
 
-    public static AccessContext ForUser(UserKey userKey, string action, TenantKey? tenant = null)
+    public static AccessContext ForUser(
+        UserKey userKey,
+        string action,
+        TenantKey? tenant = null,
+        SessionChainId? actorChainId = null,
+        string resource = "identifier")
     {
         var t = tenant ?? TenantKey.Single;
 
@@ -31,12 +36,36 @@ public static AccessContext ForUser(UserKey userKey, string action, TenantKey? t
             actorTenant: t,
             isAuthenticated: true,
             isSystemActor: false,
-            actorChainId: null,
-            resource: "identifier",
+            actorChainId: actorChainId,
+            resource: resource,
             targetUserKey: userKey,
             resourceTenant: t,
             action: action,
             attributes: EmptyAttributes.Instance
         );
     }
+
+    public static AccessContext ForTargetUser(
+        UserKey actorUserKey,
+        UserKey targetUserKey,
+        string action,
+        TenantKey? tenant = null,
+        SessionChainId? actorChainId = null,
+        string resource = "identifier")
+    {
+        var t = tenant ?? TenantKey.Single;
+
+        return new AccessContext(
+            actorUserKey: actorUserKey,
+            actorTenant: t,
+            isAuthenticated: true,
+            isSystemActor: false,
+            actorChainId: actorChainId,
+            resource: resource,
+            targetUserKey: targetUserKey,
+            resourceTenant: t,
+            action: action,
+            attributes: EmptyAttributes.Instance
+        );
+    }
 }