Skip to content

Code and UI review request #883

Description

@GoogleCodeExporter
Branch name: improved-skin

Link to the relevant commit(s): 
https://code.google.com/p/oppia/source/detail?r=411c950b923f077398f085ede55b9690
dcb5fdb2&name=improved-skin

Purpose of code changes on this branch: Implement the redesign of the learner 
view skin.

When reviewing my code changes, please focus on:
  - Amit: UI; Ben: code. Also please note question below about merging.
  - Amit: I still need to do the following:
    * When going to a new state that contains a supplement, the tutor card should move to the left (if necessary) and the supplement should fade in. When leaving such a state, the tutor card should move to the center (if necessary) and the supplement should fade out.
    * Expanding and contracting previous answers within a card should be an animation. [@Amit: what exactly should happen here -- fade out, height change, fade in? Or some kind of scroll-down?]
    * The learner's answer in the card should be abbreviated, and there should be a tooltip showing the full thing. [This is pending Ben's work.]
    * Redesign EndExploration following Amit's mocks.
    * Modify the existing demo exploration to show off all the interactions nicely.


After the review, I'll merge this branch into:
  - I'd like to merge this into develop as soon as possible, and do some of the above as incremental changes on top of it thereafter. @Amit, @Ben: from UI and technical points of view, what would you say are the minimum requirements for a merge to develop?

Original issue reported on code.google.com by s...@google.com on 31 Jul 2015 at 5:18

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions