Repository navigation
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 91bd911: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🟡 Known Nightly Failures: 4 of the tests that failed in recording also fail or are flaky in the last 30 days of nightly runs, so they may be unrelated to this PR. In nightly findings, ⚪ means the test already fails in nightly, 🟡 that it is flaky there, and 🔴 that it is healthy in nightly and so more likely broken by this PR. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @yifanyang, @slevenick VCR tests complete for 91bd911! |
|
@xiangwa Can you help perform a local review for this change per http://go/terraform-contribution-guide? This fixes the error detail dropping at the Terraform layer. Context: http://go/orcas-rfc-997 (http://b/510762188) |
|
@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
Hello @slevenick, quick context for review:
|
When a long-running operation fails, the provider prints only the code and message of the returned
google.rpc.Status(Error code 3, message: ...). The statusdetailsare already decoded intotpgresource.CommonOpErrorbut never printed, so users miss the error reason (google.rpc.ErrorInfo) and troubleshooting links (google.rpc.Help) that APIs following AIP-193 return. For example, Vertex AI Agent Engine is starting to report failed deployments with a reason such asREASONING_ENGINE_BUILD_FAILED, a link to the build logs, and a link to the matching troubleshooting page; Terraform users currently see none of them.CommonOpError.Error()now appends the details as indented JSON, the same formatgoogleapi.Erroralready uses for failed synchronous requests. Errors without details print exactly as before. The change applies to every resource whose operation waiter usesCommonOperationWaiter.Error(), including all generated*_operation.gowaiters. The first line is unchanged, so retry predicates that match on error text keep matching.Example (
google_vertex_ai_reasoning_engine, values shortened):Before this change, the output stopped after the first line.