Repository navigation
managedkafka: add network target fields to cluster - #20051
Draft
zhewenfu-goog wants to merge 1 commit into
Draft
zhewenfu-goog wants to merge 1 commit into
zhewenfu-goog wants to merge 1 commit into
Conversation
Adds psc_resource_target and dns_zone_target to gcp_config.access_config.network_configs of google_managed_kafka_cluster, with a new managedkafka_cluster_network_targets sample.
Author
|
Closing/reopening to re-trigger the pull_request_target workflows that hit startup_failure right after the fork was created. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
psc_resource_targetanddns_zone_targettogcp_config.access_config.network_configsofgoogle_managed_kafka_cluster.These fields control, per subnet, whether the Private Service Connect endpoints and the private DNS zone are created in the network's (Shared VPC host) project or in the cluster's (service) project. They map to the v1 API fields
NetworkConfig.psc_resource_target/NetworkConfig.dns_zone_target, which reach GA with the Managed Service for Apache Kafka cross-project network controls launch (December 2026).Modeling notes for reviewers
type: Stringwith the possible values listed in the description, per the repo's enum-vs-string guidance.default_from_api: true: for Shared VPC subnets the API normalizes an unset value toPSC_NETWORK_PROJECT/DNS_ZONE_NETWORK_PROJECTand returns it; for same-project subnets it echoes whatever was requested (empty if unset).immutable: true. The API enforces immutability per subnet (changing the value of an already-attached subnet fails withINVALID_ARGUMENT), while adding or removing subnets remains an in-place update. AForceNewon a list element would instead plan a destroy/recreate of the cluster.managedkafka_cluster_network_targetscovers both fields in a test step. It uses a same-project subnet because the acceptance test project is not a Shared VPC service project; the API accepts and persists the values for same-project subnets as well.Draft until the API fields are publicly available. The v1 API rollout exposing these fields is scheduled to complete in mid December 2026; acceptance tests / VCR recordings cannot pass before then. I will mark the PR ready for review once the rollout is complete.
Fixes b/569982665
Release Note Template for Downstream PRs (will be copied)