Skip to content

Refactor save to improve compatibility with old software - #18

Merged
juliohm merged 13 commits into
mainfrom
save-refactor
Jul 17, 2026
Merged

juliohm merged 13 commits into
mainfrom
save-refactor

Conversation

@juliohm

@juliohm juliohm commented Jul 16, 2026 •

Copy link
Copy Markdown
Member

Old software cannot load rev 2.1, so we should be conservative if the extended headers are empty. This PR refactors Segy.save to stick to rev 1.0 when that is possible.

@codecov-commenter

codecov-commenter commented Jul 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.46154% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.69%. Comparing base (bd0f076) to head (f83202a).

Files with missing lines Patch % Lines
src/segy/save.jl 83.78% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   65.22%   64.69%   -0.54%     
==========================================
  Files          19       17       -2     
  Lines         463      473      +10     
==========================================
+ Hits          302      306       +4     
- Misses        161      167       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliohm
juliohm marked this pull request as ready for review July 16, 2026 22:17
@juliohm
juliohm merged commit 50b108b into main Jul 17, 2026
7 checks passed
@juliohm
juliohm deleted the save-refactor branch July 17, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants