Repository navigation
Refactor save to improve compatibility with old software - #18
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 65.22% 64.69% -0.54%
==========================================
Files 19 17 -2
Lines 463 473 +10
==========================================
+ Hits 302 306 +4
- Misses 161 167 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
juliohm
marked this pull request as ready for review
July 16, 2026 22:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old software cannot load rev 2.1, so we should be conservative if the extended headers are empty. This PR refactors
Segy.saveto stick to rev 1.0 when that is possible.