Skip to content

Ignore revision number in number type logic, only emit a warning - #19

Merged
juliohm merged 3 commits into
mainfrom
format-code-warn
Jul 23, 2026
Merged

juliohm merged 3 commits into
mainfrom
format-code-warn

Conversation

@juliohm

@juliohm juliohm commented Jul 23, 2026

Copy link
Copy Markdown
Member

To mimic the behavior of software that don't adhere to the SEG-Y standard.

@codecov-commenter

codecov-commenter commented Jul 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.64%. Comparing base (7c848e2) to head (824bbb7).

Files with missing lines Patch % Lines
src/segy/utils.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
- Coverage   64.84%   64.64%   -0.20%     
==========================================
  Files          17       17              
  Lines         475      478       +3     
==========================================
+ Hits          308      309       +1     
- Misses        167      169       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliohm
juliohm merged commit 2923887 into main Jul 23, 2026
7 checks passed
@juliohm
juliohm deleted the format-code-warn branch July 23, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants