Repository navigation
Export rcond, condest, and rgrowth - #43
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 62.41% 69.29% +6.87%
==========================================
Files 2 2
Lines 620 622 +2
==========================================
+ Hits 387 431 +44
+ Misses 233 191 -42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ViralBShah
force-pushed
the
export-condition-estimates
branch
2 times, most recently
from
October 30, 2026 19:59
fa566c4 to
d77a81c
Compare
Member
Author
|
Review fixes in 2e48bd5. |
These were already defined and correct, but had to be qualified with `KLU.` to be used. rgrowth is exported too, as it is part of the same family of functions. Fixes #29 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
klu_rgrowth resets Common->status to KLU_OK, so calling the now exported rgrowth made a singular factorization report issuccess(F) == true. Restore the status after the call. The docstrings were inside the @eval loop, which gave each function four identical copies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ViralBShah
force-pushed
the
export-condition-estimates
branch
from
October 30, 2026 20:50
2e48bd5 to
6646a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29.
rcondandcondestalready worked but weren't exported, sousing KLU; rcond(klu(A))threwUndefVarError. This PR exports them, along withrgrowth, which is part of the same family, and adds all three to the API list in the docs.None of the three names exists in Base, LinearAlgebra or SparseArrays on Julia 1.13, and unqualified use works alongside
using LinearAlgebraon 1.10. Other packages weren't checked for clashes.LinearAlgebra.condisn't extended, because it defaults to the 2-norm andcondestestimates the 1-norm.Testing
The new tests cover real and complex values with Int32 and Int64 indices, and compare results against independent calculations from the factors and dense matrices. They also cover refactorization, computing the factorization on demand, and singular matrices. The full suite passes locally on macOS with Julia 1.13 at
-t 2.🤖 Generated with Claude Code