Repository navigation
Set the version to 0.6.1 and stop exporting solve! - #61
Merged
Merged
Conversation
Another package that exports its own solve! makes an unqualified solve! ambiguous when both are loaded, so it fails with UndefVarError. KLU.solve! is still available, and the docs and tests now use that name. Also test that klu_analyze! rejects invalid permutations on a factorization that has already been analyzed. It ignored them in 0.6.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
=======================================
Coverage 97.29% 97.29%
=======================================
Files 1 1
Lines 407 407
=======================================
Hits 396 396
Misses 11 11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets the version to 0.6.1 for the release of the changes on
main, and stops exportingsolve!.Behaviour changes
solve!is no longer exported. It was added to the exports after 0.6.0 and has never been released as an export. If another package exports its ownsolve!, loading both makes an unqualifiedsolve!ambiguous, so it fails withUndefVarError.KLU.solve!still works, and the README, docs and tests now use that name.Release notes for 0.6.1
solve!isn't exported, so useKLU.solve!.klu_analyze!(F, P, Q)throws anArgumentErrorfor invalid permutations, including on a factorization that has already been analyzed, where 0.6.0 ignored them. This PR adds a test for that case.Testing
On Apple silicon macOS, the test suite passes on Julia 1.12 and 1.13, and Aqua and the docs build pass on 1.12. With a dummy package that exports its own
solve!, loaded alongside KLU, itssolve!andKLU.solve!both work. Linux and Windows are left to CI.🤖 Generated with Claude Code