linstor tests: use the small marvin-alpine guest template when registered

Add get_guest_template() to linstor_test_utils and use it in the volume,
encrypted-snapshot and incremental-snapshot tests. It picks the purpose-built
~512 MiB "marvin-alpine" USER template registered by
`cs-linstor.py setup-test-template` and falls back to the builtin template
when it is absent, so no extra setup is required.

The builtin CentOS template is an 8 GiB volume that takes ~55s to reach sshd,
and creating an encrypted volume from it forces a full block-level re-encrypt
copy of the whole virtual size (~500s per VM). A small template makes that
negligible.

Author: rp-

test/integration/plugins/linstor/linstor_test_utils.py

@@ -20,6 +20,35 @@
 import socket
 import time
 
+from marvin.codes import FAILED
+from marvin.lib.common import get_template
+
+# Registered by `cs-linstor.py setup-test-template`. Optional: clusters without it fall
+# back to the builtin template, so nothing here requires the extra setup step.
+TEST_TEMPLATE_NAME = "marvin-alpine"
+
+
+def get_guest_template(api_client, zone_id, hypervisor="KVM", name=TEST_TEMPLATE_NAME):
+    """The small purpose-built guest template if it is registered, else the builtin one.
+
+    The builtin CentOS 5.5 template is an 8 GiB volume that takes ~55s to reach sshd.
+    Worse, creating an *encrypted* volume from a template cannot share blocks with the
+    source - a new passphrase means different ciphertext - so LINSTOR does a full
+    block-level re-encrypt copy of the whole virtual size, measured at ~500s per VM.
+    A ~512 MiB template makes that negligible.
+
+    Note marvin's get_template() only returns FAILED when the list call itself comes back
+    empty; otherwise it falls through to the first result even if nothing matched the
+    requested type. So detection has to key off FAILED, and the type has to be USER
+    because our template is registered rather than built in.
+    """
+    template = get_template(api_client, zone_id, template_filter="all",
+                            template_type="USER", template_name=name,
+                            hypervisor=hypervisor)
+    if template != FAILED and getattr(template, "isready", False):
+        return template
+    return get_template(api_client, zone_id, hypervisor=hypervisor)
+
 
 class ServiceReady:
     @classmethod

test/integration/plugins/linstor/test_linstor_encrypted_snapshots.py

@@ -28,12 +28,12 @@
 from marvin.cloudstackException import CloudstackAPIException
 from marvin.lib.base import Account, Configurations, Host, ServiceOffering, \
     Snapshot, StoragePool, User, VirtualMachine, Volume
-from marvin.lib.common import get_domain, get_template, get_zone, list_hosts, list_virtual_machines, list_volumes
+from marvin.lib.common import get_domain, get_zone, list_hosts, list_virtual_machines, list_volumes
 from marvin.lib.utils import cleanup_resources
 from marvin.sshClient import SshClient
 from nose.plugins.attrib import attr
 
-from linstor_test_utils import ServiceReady
+from linstor_test_utils import ServiceReady, get_guest_template
 
 # Prerequisites:
 #  Only one zone / pod / cluster
@@ -141,7 +141,7 @@ def setUpClass(cls):
 
         cls.zone = get_zone(cls.apiClient, zone_id=cls.testdata[TestData.zoneId])
         cls.domain = get_domain(cls.apiClient, cls.testdata[TestData.domainId])
-        cls.template = get_template(cls.apiClient, cls.zone.id, hypervisor="KVM")
+        cls.template = get_guest_template(cls.apiClient, cls.zone.id, hypervisor="KVM")
 
         # Host SSH credentials, only needed by test_03 to inspect the backed-up qcow2 on secondary
         # storage. A full marvin config carries these under zones->pods->clusters->hosts, but a

test/integration/plugins/linstor/test_linstor_incremental_snapshots.py

@@ -26,12 +26,12 @@
 # Import Integration Libraries
 from marvin.lib.base import Account, Configurations, ServiceOffering, \
     Snapshot, StoragePool, Template, User, VirtualMachine, Volume
-from marvin.lib.common import get_domain, get_template, get_zone, list_hosts, list_virtual_machines, list_volumes
+from marvin.lib.common import get_domain, get_zone, list_hosts, list_virtual_machines, list_volumes
 from marvin.lib.utils import cleanup_resources
 from marvin.sshClient import SshClient
 from nose.plugins.attrib import attr
 
-from linstor_test_utils import ServiceReady
+from linstor_test_utils import ServiceReady, get_guest_template
 
 # Prerequisites:
 #  Only one zone / pod / cluster
@@ -140,7 +140,7 @@ def setUpClass(cls):
 
         cls.zone = get_zone(cls.apiClient, zone_id=cls.testdata[TestData.zoneId])
         cls.domain = get_domain(cls.apiClient, cls.testdata[TestData.domainId])
-        cls.template = get_template(cls.apiClient, cls.zone.id, hypervisor="KVM")
+        cls.template = get_guest_template(cls.apiClient, cls.zone.id, hypervisor="KVM")
 
         # Host SSH credentials, needed by the tests that inspect or manipulate the backed-up qcow2
         # files on secondary storage. A full marvin config carries these under

test/integration/plugins/linstor/test_linstor_volumes.py

@@ -29,15 +29,15 @@
 from marvin.lib.base import VirtualMachine, Volume, VmSnapshot
 
 # common - commonly used methods for all tests are listed here
-from marvin.lib.common import get_domain, get_template, get_zone, list_clusters, list_hosts, list_virtual_machines, \
+from marvin.lib.common import get_domain, get_zone, list_clusters, list_hosts, list_virtual_machines, \
     list_volumes
 
 # utils - utility classes for common cleanup, external library wrappers, etc.
 from marvin.lib.utils import cleanup_resources, validateList
 from marvin.codes import PASS
 from nose.plugins.attrib import attr
 
-from linstor_test_utils import ServiceReady
+from linstor_test_utils import ServiceReady, get_guest_template
 
 # Prerequisites:
 #  Only one zone
@@ -260,7 +260,7 @@ def setUpClass(cls):
         # Get Resources from Cloud Infrastructure
         cls.zone = get_zone(cls.apiClient, zone_id=cls.testdata[TestData.zoneId])
         cls.cluster = list_clusters(cls.apiClient)[0]
-        cls.template = get_template(cls.apiClient, cls.zone.id, hypervisor=TestData.hypervisor_type)
+        cls.template = get_guest_template(cls.apiClient, cls.zone.id, hypervisor=TestData.hypervisor_type)
         cls.domain = get_domain(cls.apiClient, cls.testdata[TestData.domainId])
 
         # Create test account