Repository navigation
Attach an out-of-scope home repo with add_repo before falling back to filing elsewhere - #4786
Conversation
… attach it A cloud session with add_repo reaches any repo the account can, so the "file in the current working repo" fallback does not apply there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDkNzmY4nBZGU49XsAZWUa
Review found the separate bullet overstated add_repo's reach, contradicted the fallback above it, and duplicated default-to-action-grants. Link that fragment instead and make the fallback conditional on add_repo refusing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VDkNzmY4nBZGU49XsAZWUa
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Claude finished review — View run No new findings. The diff content, verification evidence, and conclusion all match the prior round's review: prior round review, which found the diff a clean, self-contained 9-line documentation addition with all three cited artifacts (ai-config#4785, the comment on ai-config#4712, and the comment on ai-config#3544) resolving and matching their claimed content, and the linked fragment VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "433219d",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The PR's actual diff in shared/workflow/report-mistakes-proactively.md is unchanged from the prior clean round; the two new commits only merge in an unrelated shared/writing/citations.md change from main.",
"holistic_assessment": "No new requirement, integration, regression, or validation concern arose since the prior round; all three cited forge artifacts and the linked fragment still resolve and match their claimed content."
}Reviewed commit: 62d5e63 |
|
Merging under ai-config's standing merge grant. The cross-model adversarial review was waived: no qualifying reviewer could run from this cloud session.
A separate Claude adversarial-reviewer subagent reviewed Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
Extends the "When the session can't reach the home repo" bullet in
shared/workflow/report-mistakes-proactively.md.A repo outside the session's GitHub scope is not yet unreachable when the session has an
add_repotool.The bullet now says to attach it first, without asking, per
default-to-action-grants, and to fall back to filing in the current repo only whenadd_reporefuses.Why
On 2026-10-27 a cloud session working in
Morrison-Lab/mlgfound three ai-config tooling defects.It reported them as unfiled because ai-config was outside the session's scope, then asked the user what to do once they attached it.
The user answered
daytb.The existing fallback bullet read "not in the session's GitHub scope" as unreachable, which let that happen.
The defects are now tracked as #4785 and comments on #4712 and #3544.
Review
A separate adversarial-reviewer subagent rejected the first draft (a new bullet): it overstated what
add_repocan reach, contradicted the fallback above it, and duplicateddefault-to-action-grants.The second commit folds the change into the existing bullet; the re-review on
f1a32f2was clean, with one optional nit (posting still passes the membership gate), which the preceding bullets' limit to repos we administrate already covers.Checks
check-links.py,check-ascii-punctuation.py,check-mistake-patterns.pyandcheck-bare-fragment-mentions.pypass.Generated by Claude Code