Skip to content

Commit 195aaf6

Browse files
committed
refactor(config): name configuration delivery parts consistently
Call the whole component configuration delivery and name its parts after what they do. The synchronous Scheduler becomes DeliveryQueue (queue.rs) and the task that drains it becomes the delivery worker. SupervisorConfigRouter becomes SupervisorConfigTransport, because "route" also named cross-replica work. That work, its peer messages (PeerNotifyConfigUpdateRequest/Response, matching the RPC), and its metrics now say peer notification instead of hint. Lane::Direct becomes Lane::Sandbox to match the sandbox-scoped wording used elsewhere. Metric changes: - openshell_supervisor_config_dispatch_wait_seconds is now openshell_supervisor_config_queue_wait_seconds - openshell_supervisor_config_peer_hints_total is now openshell_supervisor_config_peer_notifications_total - openshell_supervisor_config_pending lane labels direct and route are now sandbox and peer_notify Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
1 parent 9a0ca49 commit 195aaf6

18 files changed

Lines changed: 545 additions & 541 deletions

‎crates/openshell-cli/tests/ensure_providers_integration.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ impl TestOpenShell {
8181
impl OpenShell for TestOpenShell {
8282
async fn peer_notify_config_update(
8383
&self,
84-
_request: tonic::Request<openshell_core::proto::PeerConfigUpdateHintRequest>,
85-
) -> Result<Response<openshell_core::proto::PeerConfigUpdateHintResponse>, Status> {
84+
_request: tonic::Request<openshell_core::proto::PeerNotifyConfigUpdateRequest>,
85+
) -> Result<Response<openshell_core::proto::PeerNotifyConfigUpdateResponse>, Status> {
8686
Err(Status::unimplemented("not used by this test server"))
8787
}
8888

‎crates/openshell-cli/tests/mtls_integration.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ struct TestOpenShell;
3434
impl OpenShell for TestOpenShell {
3535
async fn peer_notify_config_update(
3636
&self,
37-
_request: tonic::Request<openshell_core::proto::PeerConfigUpdateHintRequest>,
38-
) -> Result<Response<openshell_core::proto::PeerConfigUpdateHintResponse>, Status> {
37+
_request: tonic::Request<openshell_core::proto::PeerNotifyConfigUpdateRequest>,
38+
) -> Result<Response<openshell_core::proto::PeerNotifyConfigUpdateResponse>, Status> {
3939
Err(Status::unimplemented("not used by this test server"))
4040
}
4141

‎crates/openshell-cli/tests/provider_commands_integration.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -234,8 +234,8 @@ impl TestOpenShell {
234234
impl OpenShell for TestOpenShell {
235235
async fn peer_notify_config_update(
236236
&self,
237-
_request: tonic::Request<openshell_core::proto::PeerConfigUpdateHintRequest>,
238-
) -> Result<Response<openshell_core::proto::PeerConfigUpdateHintResponse>, Status> {
237+
_request: tonic::Request<openshell_core::proto::PeerNotifyConfigUpdateRequest>,
238+
) -> Result<Response<openshell_core::proto::PeerNotifyConfigUpdateResponse>, Status> {
239239
Err(Status::unimplemented("not used by this test server"))
240240
}
241241

‎crates/openshell-cli/tests/sandbox_create_lifecycle_integration.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ struct TestOpenShell {
103103
impl OpenShell for TestOpenShell {
104104
async fn peer_notify_config_update(
105105
&self,
106-
_request: tonic::Request<openshell_core::proto::PeerConfigUpdateHintRequest>,
107-
) -> Result<Response<openshell_core::proto::PeerConfigUpdateHintResponse>, Status> {
106+
_request: tonic::Request<openshell_core::proto::PeerNotifyConfigUpdateRequest>,
107+
) -> Result<Response<openshell_core::proto::PeerNotifyConfigUpdateResponse>, Status> {
108108
Err(Status::unimplemented("not used by this test server"))
109109
}
110110

‎crates/openshell-cli/tests/sandbox_exec_streaming_integration.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ mock_gateway! {
274274
peer_report_provider_readiness(proto::ReportProviderReadinessRequest) -> proto::ReportProviderReadinessResponse;
275275
peer_report_endpoint_status(proto::ReportEndpointStatusRequest) -> proto::ReportEndpointStatusResponse;
276276
peer_get_sandbox_provider_status(proto::GetSandboxProviderStatusRequest) -> proto::GetSandboxProviderStatusResponse;
277-
peer_notify_config_update(proto::PeerConfigUpdateHintRequest) -> proto::PeerConfigUpdateHintResponse;
277+
peer_notify_config_update(proto::PeerNotifyConfigUpdateRequest) -> proto::PeerNotifyConfigUpdateResponse;
278278
submit_policy_analysis(proto::SubmitPolicyAnalysisRequest) -> proto::SubmitPolicyAnalysisResponse;
279279
get_draft_policy(proto::GetDraftPolicyRequest) -> proto::GetDraftPolicyResponse;
280280
approve_draft_chunk(proto::ApproveDraftChunkRequest) -> proto::ApproveDraftChunkResponse;

‎crates/openshell-cli/tests/sandbox_name_fallback_integration.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ struct TestOpenShell {
4949
impl OpenShell for TestOpenShell {
5050
async fn peer_notify_config_update(
5151
&self,
52-
_request: tonic::Request<openshell_core::proto::PeerConfigUpdateHintRequest>,
53-
) -> Result<Response<openshell_core::proto::PeerConfigUpdateHintResponse>, Status> {
52+
_request: tonic::Request<openshell_core::proto::PeerNotifyConfigUpdateRequest>,
53+
) -> Result<Response<openshell_core::proto::PeerNotifyConfigUpdateResponse>, Status> {
5454
Err(Status::unimplemented("not used by this test server"))
5555
}
5656

‎crates/openshell-sdk/tests/client_mock.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,8 +236,8 @@ fn workload_template_proto(name: &str, workspace: &str) -> proto::SandboxWorkloa
236236
impl OpenShell for TestOpenShell {
237237
async fn peer_notify_config_update(
238238
&self,
239-
_request: tonic::Request<proto::PeerConfigUpdateHintRequest>,
240-
) -> Result<Response<proto::PeerConfigUpdateHintResponse>, Status> {
239+
_request: tonic::Request<proto::PeerNotifyConfigUpdateRequest>,
240+
) -> Result<Response<proto::PeerNotifyConfigUpdateResponse>, Status> {
241241
Err(Status::unimplemented("not used by this test server"))
242242
}
243243

0 commit comments

Comments
 (0)