Skip to content

Commit 6ec9c0a

Browse files
committed
fix(ssh): integrate stable host keys with current main
Signed-off-by: Mike Nguyen <miken@nvidia.com>
2 parents a645d9f + 71c3cd9 commit 6ec9c0a

228 files changed

Lines changed: 19728 additions & 12581 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.agents/skills/build-from-issue/SKILL.md‎

Lines changed: 17 additions & 743 deletions
Large diffs are not rendered by default.

‎.agents/skills/build-openshell-mxc-windows/SKILL.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,8 @@ compatibility under emulation is not part of these tasks. The aggregate
215215
commands above on an ARM64 host.
216216

217217
The repository-wide `mise run pre-commit` task is also supported on Windows.
218-
Run `rust:lockfiles:check`, `sdk:ts:ci`, `go:ci`, and `test:e2e-parity` through
219-
the Windows-aware tasks when validating those surfaces. Do not count the Go
218+
Run `rust:lockfiles:check`, `sdk:ts:ci`, and `go:ci` through the Windows-aware
219+
tasks when validating those surfaces. Do not count the Go
220220
Windows ARM64 race-detector exclusion or POSIX permission-bit skips as security
221221
coverage. SDK test dependencies must remain at their lockfile versions.
222222
Its Rust check, Clippy, and test dependencies enter the same MSVC environment
@@ -265,7 +265,7 @@ MXC on Windows. Each other `compute-driver-*` feature installs its own Windows
265265
rejection stub without linking that driver crate. The default
266266
`in-tree-compute-drivers` alias enables all five features. An MXC-only build
267267
uses `--no-default-features --features compute-driver-mxc` (add `telemetry`
268-
and `bundled-z3` as needed).
268+
and `openshell-server/prebuilt-z3` as needed).
269269

270270
| Driver | Windows build behavior | Runtime behavior |
271271
|---|---|---|

‎.agents/skills/create-github-issue/SKILL.md‎

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ This project uses YAML form issue templates. When creating issues, match the tem
1919

2020
### Bug Reports
2121

22-
Do not add a type label automatically. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, and **Acceptance Criteria**, followed by bug-specific reproduction steps and environment details. Logs are optional and must be concise and redacted. Apply area or topic labels only when they are clearly known.
22+
Do not add a type label automatically. Confirm that the human operator personally uses OpenShell and directly encountered the problem or needs the feature for a specific use case. If that first-hand attestation or concrete use case is missing, ask for it before creating the issue. Frame the issue entirely in terms of OpenShell. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, and **Acceptance Criteria**, followed by bug-specific reproduction steps using only OpenShell deployments and environment details. Do not install third-party tools to demonstrate reproducibility. Logs are optional and must be concise and redacted. If the issue suggests a change to configuration, CLI, SDK, or other user experience, include a notional example of the proposed interaction for human review. Inspect current repository labels before applying any; use only labels whose meaning is clear.
2323

2424
```bash
2525
gh issue create \
2626
--title "bug: <concise description>" \
2727
--body "$(cat <<'EOF'
2828
## User Story
2929
30-
As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
30+
I use OpenShell for <specific use case>. I directly encountered or need <specific behavior> so that <outcome>.
3131
3232
## Problem Statement
3333
@@ -52,26 +52,28 @@ As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
5252
- OS: <os>
5353
- Runtime, deployment, or integration: <relevant details>
5454
55+
## Suggested UX (if applicable)
56+
57+
<Notional OpenShell CLI, configuration, SDK, or other interaction>
58+
5559
## Logs
5660
57-
```
58-
<optional minimal, redacted output>
59-
```
61+
<Optional minimal, redacted output>
6062
EOF
6163
)"
6264
```
6365

6466
### Feature Requests
6567

66-
Do not add a type label automatically. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, **Proposed Design**, **Acceptance Criteria**, and **Alternatives Considered**. The proposed design should define the user-facing workflow and externally observable behavior without prescribing internal implementation. Agent investigation is optional. Apply area or topic labels only when they are clearly known.
68+
Do not add a type label automatically. Confirm that the human operator personally uses OpenShell and directly encountered the problem or needs the feature for a specific use case. If that first-hand attestation or concrete use case is missing, ask for it before creating the issue. Frame the issue entirely in terms of OpenShell. The body must include a **User Story**, **Problem Statement**, **Impact / Why This Matters**, **Proposed Design**, **Acceptance Criteria**, and **Alternatives Considered**. The proposed design should define the user-facing workflow and externally observable behavior without prescribing internal implementation. Agent investigation is optional. If the issue suggests a change to configuration, CLI, SDK, or other user experience, include a notional example of the proposed interaction for human review. Inspect current repository labels before applying any; use only labels whose meaning is clear.
6769

6870
```bash
6971
gh issue create \
7072
--title "feat: <concise description>" \
7173
--body "$(cat <<'EOF'
7274
## User Story
7375
74-
As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
76+
I use OpenShell for <specific use case>. I directly encountered or need <specific behavior> so that <outcome>.
7577
7678
## Problem Statement
7779
@@ -85,13 +87,17 @@ As a <persona>, I want <capability or outcome>, so that <benefit or impact>.
8587
8688
<The desired user-facing workflow and externally observable behavior, without prescribing internal implementation>
8789
90+
## Suggested UX (if applicable)
91+
92+
<Notional OpenShell CLI, configuration, SDK, or other interaction>
93+
8894
## Acceptance Criteria
8995
9096
- [ ] <specific, observable outcome>
9197
9298
## Alternatives Considered
9399
94-
<Other user-facing workflows or behaviors considered and why this approach best satisfies the user story>
100+
<Other OpenShell workflows considered, including relevant middleware, interceptors, providers, or other extension points, and why the proposal better serves the use case. Prefer an applicable extension when it satisfies the use case; running another service alone is not a reason to dismiss it.>
95101
96102
## Agent Investigation
97103
@@ -102,12 +108,16 @@ EOF
102108

103109
### Tasks
104110

105-
For internal tasks that don't fit bug/feature templates:
111+
For internal tasks that do not fit bug/feature templates, still obtain the operator's first-hand OpenShell use case before creating the issue:
106112

107113
```bash
108114
gh issue create \
109115
--title "<type>: <description>" \
110116
--body "$(cat <<'EOF'
117+
## User Story
118+
119+
<I personally use OpenShell for this specific case and directly need this work because...>
120+
111121
## Description
112122
113123
<Clear description of the work>
@@ -125,7 +135,7 @@ EOF
125135

126136
GitHub built-in issue types (`Bug`, `Feature`, `Task`) should come from the matching issue template when possible, or be set manually afterward. Do not try to emulate them through labels.
127137

128-
Creating an issue does not accept it or queue agent work. Agents never apply `state:accepted`, the `roadmap` label, add issues to the roadmap project, or apply `agent:plan-requested` or `agent:implementation-requested`. Community issues proceed through `triage-issue`; a human accepts technically validated work with `state:accepted` or roadmap placement. The request labels queue work for unattended agents. A user may instead direct an agent to a specific issue; the agent warns about missing expected workflow labels and continues with the requested phase without changing them.
138+
Creating an issue does not accept it. Inspect the repository’s current `state:*` labels and follow its triage → validation → human acceptance process. Agents may assess facts, but only humans decide whether to accept work or place it on the roadmap. A direct user request authorizes the requested planning or implementation phase without changing issue disposition.
129139

130140
## Useful Options
131141

@@ -150,5 +160,5 @@ Created issue [#123](https://github.com/OWNER/REPO/issues/123)
150160

151161
Use the issue number to:
152162

153-
- Reference in commits: `git commit -m "Fix validation error (fixes #123)"`
154-
- Create a branch following project convention: `<issue-number>-<description>/<username>`
163+
- Reference in signed-off Conventional Commits: `git commit --signoff -m "fix(cli): validate empty requests (fixes #123)"`
164+
- Create a branch following project convention: `<type>/<issue-id>-<short-description>/<github-username>`, where `<type>` is a Conventional Commits type.

‎.agents/skills/create-github-pr/SKILL.md‎

Lines changed: 23 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ Create pull requests on GitHub using the `gh` CLI.
1313

1414
- The `gh` CLI must be authenticated (`gh auth status`)
1515
- You must have commits on a branch that's pushed to the remote
16-
- For issue-backed work, the branch should follow `<issue-number>-<description>/<username>`. Exempt issue-less changes may use `<description>/<username>`.
16+
- Every PR must close an existing issue. The branch should follow `<type>/<issue-id>-<short-description>/<github-username>`.
1717

1818
## Before Creating a PR
1919

@@ -30,13 +30,11 @@ deployment docs.
3030

3131
Use the `sync-agent-infra` skill's maintenance map to identify related skill updates when the branch changes behavior, commands, or development workflows. Run its full consistency check when the branch adds, removes, or renames skills or crates; changes workflow relationships or skill coverage; modifies issue or PR templates; or changes agent cross-references. Resolve any drift before creating the PR.
3232

33-
### Run Pre-commit Checks
33+
### Verify the Affected Areas
3434

35-
Run the local pre-commit task before opening a PR:
35+
Use the verification guidance in `CONTRIBUTING.md` to select checks for the changed files and behavior. Guidance, skills, and template changes need applicable Markdown, YAML, link, and consistency checks. Run Rust or SDK suites when those components or their dependencies can be affected. Shared APIs, schemas, dependencies, and build changes may require broader checks even when component source files are unchanged.
3636

37-
```bash
38-
mise run pre-commit
39-
```
37+
`mise run ci` and `mise run pre-commit` are broad convenience tasks, not blanket PR prerequisites. Broaden validation only for a concrete remaining risk or failed check, and report what actually ran.
4038

4139
### Verify Branch State
4240

@@ -49,21 +47,13 @@ Before creating a PR, verify:
4947
git branch --show-current
5048
```
5149

52-
2. **Branch follows naming convention** - Use `<issue-number>-<description>/<initials>` for issue-backed work or `<description>/<initials>` for an exempt issue-less change.
50+
2. **Branch follows naming convention** - Use `<type>/<issue-id>-<short-description>/<github-username>`, where `<type>` is a Conventional Commits type.
5351

5452
```bash
55-
# Example: 1234-add-pagination/jd
53+
# Example: feat/1234-add-pagination/johntmyers
5654
git branch --show-current
5755
```
5856

59-
3. **Consider squashing commits** - For cleaner history, squash related commits before pushing:
60-
61-
```bash
62-
# Squash last N commits into one
63-
git reset --soft HEAD~N
64-
git commit -m "feat(component): description"
65-
```
66-
6757
### Push Your Branch
6858

6959
Ensure your branch is pushed to the remote:
@@ -116,19 +106,25 @@ gh pr create --title "PR title" --body "PR description"
116106

117107
### Link to an Issue
118108

119-
Features, user-visible behavior changes, public API changes, architecture changes, and multi-PR efforts must link an accepted issue. Use `Closes #<issue-number>` in the body to auto-close the issue when merged:
109+
Every PR must close its own issue. Verify that the issue exists, remains open, and covers the PR scope. Use `Closes #<issue-number>` in the body so merge closes it:
120110

121111
```bash
122112
gh pr create \
123-
--title "Fix validation error for empty requests" \
124-
--body "Closes #123
113+
--title "fix(cli): validate empty requests" \
114+
--body "## Summary
125115
126-
## Summary
127-
- Added validation for empty request bodies
128-
- Returns 400 instead of 500"
116+
Validate empty request bodies.
117+
118+
## Related Issue
119+
120+
Closes #123
121+
122+
## Changes
123+
124+
- Return 400 instead of 500"
129125
```
130126

131-
Small documentation fixes, mechanical maintenance, and obvious localized bug fixes may omit a separate issue when the PR contains enough context to review the decision and implementation together. In that case, write `No issue required: <brief reason>` in the Related Issue section. Do not use this exception for security fixes; follow `SECURITY.md`.
127+
If the work needs multiple PRs, create a separate closable issue for each PR. A higher-level tracking issue may link the component issues, but no PR should close that tracking issue until all its work is complete. Follow `SECURITY.md` for vulnerability disclosure. First-time external contributors must be vouched before their PRs are accepted; the vouch check may close unvouched PRs. Check the current vouch process before opening a PR for an external contributor.
132128

133129
### Create as Draft
134130

@@ -138,12 +134,6 @@ For work-in-progress that's not ready for review:
138134
gh pr create --draft --title "WIP: New feature"
139135
```
140136

141-
### With Labels
142-
143-
```bash
144-
gh pr create --title "Title" --label "area:cli" --label "topic:security"
145-
```
146-
147137
### Target a Different Branch
148138

149139
Default target is `main`. To target a different branch:
@@ -161,15 +151,15 @@ PR descriptions must follow the project's [PR template](.github/PULL_REQUEST_TEM
161151
<!-- 1-3 sentences: what this PR does and why -->
162152

163153
## Related Issue
164-
<!-- Fixes #NNN / Closes #NNN, or "No issue required: <reason>" for an exempt change -->
154+
<!-- Closes #NNN; this issue covers the scope of this PR -->
165155

166156
## Changes
167157
<!-- Bullet list of key changes -->
168158

169159
## Testing
170160
<!-- What testing was done? -->
171-
- [ ] `mise run pre-commit` passes
172-
- [ ] Unit tests added/updated
161+
- [ ] Checks appropriate to the affected code and behavior pass
162+
- [ ] Unit tests added/updated (if applicable)
173163
- [ ] E2E tests added/updated (if applicable)
174164

175165
## Checklist
@@ -201,7 +191,7 @@ Closes #456
201191
202192
## Testing
203193
204-
- [x] `mise run pre-commit` passes
194+
- [x] Relevant CLI format, lint, and unit checks pass
205195
- [x] Unit tests added/updated
206196
- [ ] E2E tests added/updated (if applicable)
207197

0 commit comments

Comments
 (0)