Skip to content

Commit e2bd2a0

Browse files
committed
test(podman): install util-linux-script in the e2e guest
The e2e tests that attach a PTY to sandbox create spawn the script command through openshell_tty_cmd, which the Fedora guest does not provide, so four sandbox_lifecycle tests failed to spawn it. Install util-linux-script before the archive runs and stop excluding sandbox_lifecycle. With the package installed all 19 sandbox_lifecycle tests passed in the rootless guest. Contributes to #3712. Signed-off-by: politerealism <burdcat17@gmail.com>
1 parent ca18712 commit e2bd2a0

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

‎tests/ansible/playbooks/drivers/podman/e2e.yaml‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,14 @@
5858
ansible.builtin.command:
5959
argv: [/usr/local/bin/openshell, gateway, add, http://127.0.0.1:17670, --local, --name, tmachine]
6060

61+
# The e2e tests that attach a PTY to `openshell sandbox create` spawn
62+
# `script` (see `openshell_tty_cmd` in e2e/rust/src/harness/binary.rs).
63+
- name: Install guest tools used by the E2E archive
64+
become: true
65+
ansible.builtin.dnf:
66+
name: util-linux-script
67+
state: present
68+
6169
- name: Run Podman E2E archive tests
6270
ansible.builtin.command:
6371
argv:

‎tests/artifacts.nix‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,6 @@ let
123123
"provider_refresh_handles"
124124
"provider_token_exchange"
125125
"proxy_egress_pipeline"
126-
# Conformance covers stop/start workspace preservation and deletion while
127-
# stopped. The remaining canonical-main, TTY, attachment replay, and
128-
# no-keep cases still need migration. Nextest archive filters cannot select
129-
# individual tests, so keep the complete binary in the follow-up bucket.
130-
"sandbox_lifecycle"
131126
# Needs a prebuilt musl DNS probe in guest artifact mode; tracked in #3009.
132127
"transparent_tcp"
133128
"websocket_conformance"

0 commit comments

Comments
 (0)