Repository navigation
fix(tui): preserve quoted post-create command arguments - #4135
Closed
thotashashank302 wants to merge 1 commit into
Closed
thotashashank302 wants to merge 1 commit into
thotashashank302 wants to merge 1 commit into
Conversation
Signed-off-by: Thota shashank <thotashashank302@gmail.com>
thotashashank302
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
October 2, 2026 16:40
|
Thank you for your interest in contributing to OpenShell, @thotashashank302. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
All contributors have signed the DCO ✍️ ✅ |
4 tasks
Contributor
Author
|
I have read the DCO document and I hereby sign the DCO. |
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve quoted arguments in the TUI Create Sandbox command field.
/bin/sh -c "echo GOOD; read x"now reaches the shell as three arguments instead of splitting the script at each space. Invalid quoting leaves the form open with an error before sandbox creation is queued.Related Issue
Closes #4113
Changes
shell-words, already present in the lockfile, and retain the argument vector through post-create execution.Testing
Verified on macOS arm64 with Rust 1.95.0:
cargo fmt -p openshell-tui --checkcargo test --locked -p openshell-tui: 91 passedcargo clippy --locked -p openshell-tui --all-targets -- -D warningscargo test --locked -p openshell-cli --features openshell-server/prebuilt-z3: 640 passed, 2 integration tests and 4 doctests ignored. The prebuilt feature supplies Z3 because the system library is absent.target/debug/openshell term --helpgit diff --checkThe shell-execution tests use a local
/bin/shto verify the serialized remote command and stdin handling. A running sandbox, interactive TUI over SSH, Linux, and Windows have not been exercised. Upstream CI and maintainer review remain pending.Checklist