[Security] Harden random selection in takeRandomFromArray#7992
[Security] Harden random selection in takeRandomFromArray#7992gonzaloriestra wants to merge 1 commit into
Conversation
- Replace Math.random() with globalThis.crypto.getRandomValues() - Implement rejection sampling to avoid modulo bias - Add safety guard for empty arrays - Update return type to T | undefined to reflect empty array possibility - Add unit tests for new behavior
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/array.d.ts@@ -5,7 +5,7 @@ import type { List, ValueIteratee } from 'lodash';
* @param array - Array from which we'll select a random item.
* @returns A random element from the array.
*/
-export declare function takeRandomFromArray<T>(array: T[]): T;
+export declare function takeRandomFromArray<T>(array: T[]): T | undefined;
/**
* Returns a copy of the array deleting the elemements that are undefined.
*
|
This PR hardens the
takeRandomFromArrayutility in@shopify/cli-kitby replacing the non-cryptographically secureMath.random()with a CSPRNG (globalThis.crypto.getRandomValues()). It also implements rejection sampling to eliminate modulo bias, ensuring a truly unbiased distribution. Additionally, the function now safely handles empty arrays by returningundefinedand updating its type signature accordingly.PR created automatically by Jules for task 3547986643681095491 started by @gonzaloriestra