Skip to content

[Security] Harden random selection in takeRandomFromArray#7992

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-random-selection-3547986643681095491
Draft

[Security] Harden random selection in takeRandomFromArray#7992
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-random-selection-3547986643681095491

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

This PR hardens the takeRandomFromArray utility in @shopify/cli-kit by replacing the non-cryptographically secure Math.random() with a CSPRNG (globalThis.crypto.getRandomValues()). It also implements rejection sampling to eliminate modulo bias, ensuring a truly unbiased distribution. Additionally, the function now safely handles empty arrays by returning undefined and updating its type signature accordingly.


PR created automatically by Jules for task 3547986643681095491 started by @gonzaloriestra

- Replace Math.random() with globalThis.crypto.getRandomValues()
- Implement rejection sampling to avoid modulo bias
- Add safety guard for empty arrays
- Update return type to T | undefined to reflect empty array possibility
- Add unit tests for new behavior
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 4, 2026
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/array.d.ts
@@ -5,7 +5,7 @@ import type { List, ValueIteratee } from 'lodash';
  * @param array - Array from which we'll select a random item.
  * @returns A random element from the array.
  */
-export declare function takeRandomFromArray<T>(array: T[]): T;
+export declare function takeRandomFromArray<T>(array: T[]): T | undefined;
 /**
  * Returns a copy of the array deleting the elemements that are undefined.
  *

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant