Skip to content

Commit b26b4e8

Browse files
romainbrenguierclaude
authored andcommitted
RC-352 Rename ruling source folders to match project keys
Bump the python-test-sources submodule to a commit where the versioned folders (buildbot-0.8.6p1, django-2.2.3, mypy-0.782, ...) are renamed to their project keys, so the source path is always sources/<projectKey>. Drop the now-redundant folder arguments in PythonRulingTest and the corresponding overrides in the ruling-diff-comment action. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> GitOrigin-RevId: bb8f2237c9e7a40b6da7d67fb9455d796b04ccb8
1 parent bf80c24 commit b26b4e8

2 files changed

Lines changed: 2 additions & 11 deletions

File tree

‎.github/actions/ruling-diff-comment/ruling_diff_core_lib/models_and_constants.py‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,6 @@ def resolve_source_path(self, project: str, file_path: str) -> str:
3030
MAX_SNIPPETS_PER_RULE = 15
3131

3232
PROJECT_SOURCE_OVERRIDES = {
33-
"buildbot": "private/its/sources/buildbot-0.8.6p1",
34-
"buildbot-slave": "private/its/sources/buildbot-slave-0.8.6p1",
35-
"django": "private/its/sources/django-2.2.3",
36-
"django-cms": "private/its/sources/django-cms-3.7.1",
37-
"docker-compose": "private/its/sources/docker-compose-1.24.1",
38-
"mypy": "private/its/sources/mypy-0.782",
39-
"numpy": "private/its/sources/numpy-1.16.4",
40-
"tornado": "private/its/sources/tornado-2.3",
41-
"twisted": "private/its/sources/twisted-12.1.0",
4233
"sources_internal_ruling": "private/its/sources_internal_ruling",
4334
"namespace_basic": "private/its/sources_internal_namespace_ruling/basic_namespace",
4435
"namespace_mixed": "private/its/sources_internal_namespace_ruling/mixed_namespace",

‎.github/actions/ruling-diff-comment/test_ruling_diff.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,8 +499,8 @@ def test_resolve_source_path_for_project_rulings_returns_primary_on_miss(self) -
499499
def test_resolve_source_path_uses_project_overrides(self) -> None:
500500
io_impl = io.GitHubActionIO()
501501
self.assertEqual(
502-
"private/its/sources/mypy-0.782/pkg/file.py",
503-
io_impl.resolve_source_path("mypy", "pkg/file.py"),
502+
"private/its/sources_internal_namespace_ruling/basic_namespace/pkg/file.py",
503+
io_impl.resolve_source_path("namespace_basic", "pkg/file.py"),
504504
)
505505

506506
def test_resolve_source_path_uses_default_project_root(self) -> None:

0 commit comments

Comments
 (0)