Skip to content

Commit e90f2bd

Browse files
thomas-serre-sonarsourceclaude
authored andcommitted
SONARPY-5055 Fix open SonarQube issues
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> GitOrigin-RevId: baefe4b3480c24cef77f4a7a2beb2cea6ee0b274
1 parent ae84cf2 commit e90f2bd

3 files changed

Lines changed: 21 additions & 21 deletions

File tree

‎python-checks/src/main/java/org/sonar/python/checks/StringFormat.java‎

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -372,30 +372,32 @@ private boolean tryParsingNestedField() {
372372
}
373373

374374
private boolean tryParseFlagCharacter(char current) {
375-
if (current == ':') {
376-
state = FieldParseState.FORMAT;
377-
} else if (current == '}') {
378-
addCurrentField();
379-
state = FieldParseState.FINISHED;
380-
} else {
381-
parent.reportIssue(SYNTAX_ERROR_MESSAGE);
382-
return false;
375+
switch (current) {
376+
case ':' -> state = FieldParseState.FORMAT;
377+
case '}' -> {
378+
addCurrentField();
379+
state = FieldParseState.FINISHED;
380+
}
381+
default -> {
382+
parent.reportIssue(SYNTAX_ERROR_MESSAGE);
383+
return false;
384+
}
383385
}
384-
385386
return true;
386387
}
387388

388389
private boolean tryParseField(char current) {
389-
if (current == '!') {
390-
state = FieldParseState.FLAG;
391-
} else if (current == ':') {
392-
state = FieldParseState.FORMAT;
393-
} else if (current == '}') {
394-
addCurrentField();
395-
state = FieldParseState.FINISHED;
396-
} else {
397-
parent.reportIssue(SYNTAX_ERROR_MESSAGE);
398-
return false;
390+
switch (current) {
391+
case '!' -> state = FieldParseState.FLAG;
392+
case ':' -> state = FieldParseState.FORMAT;
393+
case '}' -> {
394+
addCurrentField();
395+
state = FieldParseState.FINISHED;
396+
}
397+
default -> {
398+
parent.reportIssue(SYNTAX_ERROR_MESSAGE);
399+
return false;
400+
}
399401
}
400402
return true;
401403
}

‎python-frontend/src/test/java/org/sonar/python/semantic/SymbolImplTest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.sonar.plugins.python.api.tree.QualifiedExpression;
2727
import org.sonar.plugins.python.api.tree.Tree;
2828
import org.sonar.python.PythonTestUtils;
29-
import org.sonar.python.types.InferredTypes;
3029

3130
import static org.assertj.core.api.Assertions.assertThat;
3231
import static org.sonar.python.PythonTestUtils.lastExpressionInFunction;

‎python-frontend/src/test/java/org/sonar/python/types/TypeShedTest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import java.util.List;
2424
import java.util.Map;
2525
import java.util.Set;
26-
import java.util.stream.Collectors;
2726
import org.assertj.core.groups.Tuple;
2827
import org.junit.jupiter.api.AfterEach;
2928
import org.junit.jupiter.api.BeforeEach;

0 commit comments

Comments
 (0)