TASStudio "Recording Mode" checkbox flicker

[abart27]

Summary

The TAS Studio checkbox "Recording mode" flickers when checked and playhead is moved

Repro

1. Open Bizhawk 2.6.0
2. Open TAS Studio
3. Check the "Recording Mode" checkbox
4. Scroll a bit through the piano roll. The checkbox tick flickers

Host env.

• BizHawk 2.6.0
• Windows 10
• Ryzen 3 3200G
• 6 gb usable ram

Potential fix

Im guessing this is because checked state is being programatically set somewhere, which causes a groupbox (parent control) repaint and flicker?

[vadosnaprimer]

It's meant to flicker because it's set up to be accessed from several places and serves as a master control, and yes we disable it while restoring playback.

[abart27]

It's meant to flicker

Isn't flicker... unwanted? Personally a program doesn't feel polished if controls flicker

[vadosnaprimer]

It's getting rapidly set and unset, it's not a bug.

[abart27]

I'm not saying it is. It's just a "polish" feature

[vadosnaprimer]

For longer gaps I don't see a problem in indicating on the fly that recording is disabled. And smaller gaps are always a thing too. Since UI here matches intended behavior, "polishing" it not to flicker "too often" won't improve actual workflow (but may introduce new bugs).

[abart27]

Im keeping this issue open until someone else comes along and disagrees/agrees with me

[adelikat]

Drawing can be made faster potentially, and we can make sure to only draw once per frame (perhaps it is doing multiple), and we can only draw if necessary.

If this is happening during playback then it is a performance issue too. I think this is worth taking a stab at improving

[abart27]

Cool!