Commit e2d3072
authored
Fix panic when serializing UUID-typed request parameters (#160)
generateConvertCode treated the generated "UUID" Go type the same as
"string" when building toURLValues(), emitting v.(string) for a value
that is actually stored as cloudstack.UUID. That type assertion panics
at runtime since Go requires an exact dynamic type match.
Affects managementserverid, currently the only parameter routed
through the UUID type, on listAsyncJobs, listHosts, listHostsMetrics,
triggerShutdown, cancelShutdown, prepareForShutdown,
listWebhookDeliveries, and deleteWebhookDelivery. It was previously
dormant since the parameter is optional on all of them and the setter
was never exercised by the standard generated tests.
Assert the value as UUID and convert to string, instead of asserting
it as string.1 parent 70fb49a commit e2d3072
5 files changed
Lines changed: 12 additions & 10 deletions
File tree
- cloudstack
- generate
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2842 | 2842 | | |
2843 | 2843 | | |
2844 | 2844 | | |
2845 | | - | |
| 2845 | + | |
2846 | 2846 | | |
2847 | 2847 | | |
2848 | 2848 | | |
| |||
3546 | 3546 | | |
3547 | 3547 | | |
3548 | 3548 | | |
3549 | | - | |
| 3549 | + | |
3550 | 3550 | | |
3551 | 3551 | | |
3552 | 3552 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| |||
765 | 765 | | |
766 | 766 | | |
767 | 767 | | |
768 | | - | |
| 768 | + | |
769 | 769 | | |
770 | 770 | | |
771 | 771 | | |
| |||
838 | 838 | | |
839 | 839 | | |
840 | 840 | | |
841 | | - | |
| 841 | + | |
842 | 842 | | |
843 | 843 | | |
844 | 844 | | |
| |||
914 | 914 | | |
915 | 915 | | |
916 | 916 | | |
917 | | - | |
| 917 | + | |
918 | 918 | | |
919 | 919 | | |
920 | 920 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
458 | 458 | | |
459 | 459 | | |
460 | 460 | | |
461 | | - | |
| 461 | + | |
462 | 462 | | |
463 | 463 | | |
464 | 464 | | |
| |||
878 | 878 | | |
879 | 879 | | |
880 | 880 | | |
881 | | - | |
| 881 | + | |
882 | 882 | | |
883 | 883 | | |
884 | 884 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1355 | 1355 | | |
1356 | 1356 | | |
1357 | 1357 | | |
1358 | | - | |
| 1358 | + | |
1359 | 1359 | | |
| 1360 | + | |
| 1361 | + | |
1360 | 1362 | | |
1361 | 1363 | | |
1362 | 1364 | | |
| |||
0 commit comments