Repository navigation
PostgreSQL: Support ONLY and * table inheritance markers - #2770
Open
LucaCappelletti94 wants to merge 2 commits into
Open
LucaCappelletti94 wants to merge 2 commits into
LucaCappelletti94 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
==========================================
+ Coverage 82.61% 82.62% +0.01%
==========================================
Files 42 42
Lines 35614 35632 +18
Branches 35614 35632 +18
==========================================
+ Hits 29421 29441 +20
Misses 2659 2659
+ Partials 3534 3532 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LucaCappelletti94
force-pushed
the
upstream/postgres-inheritance-markers
branch
from
October 30, 2026 07:58
a737aaf to
7dd413a
Compare
LucaCappelletti94
force-pushed
the
upstream/postgres-inheritance-markers
branch
from
October 30, 2026 11:16
7dd413a to
d10f855
Compare
Contributor
Author
|
Thanks @s5dsn-eqee for the review, I will be merging this one now. cc @alamb |
LucaCappelletti94
force-pushed
the
upstream/postgres-inheritance-markers
branch
2 times, most recently
from
October 30, 2026 17:30
ecd6a86 to
50e9e91
Compare
LucaCappelletti94
force-pushed
the
upstream/postgres-inheritance-markers
branch
from
October 30, 2026 22:31
50e9e91 to
f070ff4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT * FROM ONLY tparsed as a table namedONLYaliasedt. It displayed back unchanged, so round-trip tests could not see it, while the relation visitor reportedONLYinstead oft.ONLY (t)became a call to a functionONLY, andONLY t AS x,t*andapp.t* AS xfailed to parse.UPDATEandDELETEbehaved the same. PostgreSQL 16 accepts all of them (https://www.postgresql.org/docs/current/sql-select.html#SQL-FROM).TableFactor::Tablenow carries aninheritancefield, parsed when the newDialect::supports_table_inheritance_markersholds, which PostgreSQL and Generic enable. It holds an enum since PostgreSQL accepts at most one of the two markers on a table, andOnlyrecords whether the name was parenthesized so thatONLY (t)displays as written. A table namedonlystays reachable as"only".