Skip to content

Commit 574257b

Browse files
committed
address comments
1 parent 915bc26 commit 574257b

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

‎src/iceberg/manifest/manifest_group.cc‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -163,13 +163,11 @@ class ManifestGroup::PlanningContext {
163163
}
164164
ICEBERG_ASSIGN_OR_RAISE(auto column_name,
165165
data_file_schema->FindColumnNameById(field_id));
166-
if (!column_name.has_value()) {
167-
continue;
168-
}
169-
170-
std::string column_name_str(column_name.value());
171-
if (selected_columns.insert(column_name_str).second) {
172-
columns.push_back(std::move(column_name_str));
166+
if (column_name.has_value()) {
167+
std::string column_name_str(column_name.value());
168+
if (selected_columns.insert(column_name_str).second) {
169+
columns.push_back(std::move(column_name_str));
170+
}
173171
}
174172
}
175173
return PlanningContext(group, std::move(file_evaluator), std::move(columns));
@@ -338,6 +336,9 @@ class ManifestGroup::FilePlanningStream final : public FileScanTaskStream {
338336
using TaggedEntry = std::pair<int32_t, ManifestEntry>;
339337
using TaggedStream = std::pair<int32_t, ManifestEntryStreamPtr>;
340338

339+
// FIXME: Perhaps refactor this stream state machine into a
340+
// generic reusable ParallelStream<T> utility, similar to Iceberg Java's
341+
// ParallelIterable.
341342
Result<std::optional<TaggedEntry>> NextEntry() {
342343
while (true) {
343344
if (next_batch_stream_ == batch_streams_.size()) {

0 commit comments

Comments
 (0)