Skip to content

Commit eb235c2

Browse files
manuzhangcodex
andcommitted
fix: propagate evaluator errors directly
Co-authored-by: Codex <codex@openai.com>
1 parent 9608d42 commit eb235c2

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/iceberg/manifest/manifest_reader.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1047,11 +1047,11 @@ Result<std::unique_ptr<Iterator<ManifestEntry>>> ManifestReaderImpl::MakeEntries
10471047
std::unique_ptr<Evaluator> evaluator;
10481048
std::unique_ptr<InclusiveMetricsEvaluator> metrics_evaluator;
10491049
if (HasPartitionFilter() || HasRowFilter()) {
1050-
ICEBERG_ASSIGN_OR_RAISE(std::ignore, GetEvaluator());
1050+
ICEBERG_RETURN_UNEXPECTED(GetEvaluator());
10511051
evaluator = std::move(evaluator_);
10521052
}
10531053
if (HasRowFilter()) {
1054-
ICEBERG_ASSIGN_OR_RAISE(std::ignore, GetMetricsEvaluator());
1054+
ICEBERG_RETURN_UNEXPECTED(GetMetricsEvaluator());
10551055
metrics_evaluator = std::move(metrics_evaluator_);
10561056
}
10571057

0 commit comments

Comments
 (0)