Why doesn’t SessionDataSet implement the IAsyncDisposable interface?

[HXCK3D]

Currently, SessionDataSet implements the IDisposable interface. However, in its Dispose() method, the asynchronous Close() method is invoked synchronously.

Actual implementation:

protected virtual void Dispose(bool disposing)
{
  if (this.disposedValue)
    return;
  if (disposing)
  {
    try
    {
      //synchronous call
      this.Close().Wait();
    }
    catch
    {
    }
  }
  this.disposedValue = true;
}

Proposed implementation:

protected virtual Task DisposeAsync(bool disposing)
{
  if (this.disposedValue)
    return;
  if (disposing)
  {
    try
    {
      //asynchronous call
      await this.Close();
    }
    catch
    {
    }
  }
  this.disposedValue = true;
}

[HTHou]

Thanks for the suggestion. This has been addressed in #56, which has been merged into main.

SessionDataSet and RpcDataSet now implement IAsyncDisposable, with DisposeAsync() awaiting Close() instead of synchronously blocking on the async close path.