iterate

Author: aignas

python/uv/private/lock.bzl

@@ -118,8 +118,9 @@ def _lock_impl(ctx):
     args.run_shell.add("--quiet")
 
     # Generate a wrapper script that copies the existing output (if any) and
-    # then forwards all remaining arguments to uv. This approach works on both
-    # POSIX (bash, via $@) and Windows (cmd.exe, via %* in a .bat file).
+    # then runs uv. On POSIX, args are forwarded via exec "$@". On Windows,
+    # the full command line is embedded in the .bat file with backslash paths
+    # (CMD doesn't recognize forward slashes in executable paths).
     if ctx.attr.is_windows:
         ext = ".bat"
         lines = ["@echo off"]
@@ -149,7 +150,22 @@ def _lock_impl(ctx):
             ))
 
     if ctx.attr.is_windows:
-        lines.append("%*")
+        # Build the command line with backslash paths for CMD.
+        # args.run_info has most args; add the output/progress/quiet
+        # args that were only added directly to args.run_shell.
+        def _quote(arg):
+            if hasattr(arg, "short_path"):
+                arg = arg.short_path
+            arg = arg.replace("/", "\\")
+            return '"' + arg.replace('"', '""') + '"'
+
+        bat_args = args.run_info + [
+            "--output-file",
+            output,
+            "--no-progress",
+            "--quiet",
+        ]
+        lines.append(" ".join([_quote(a) for a in bat_args]))
     else:
         lines.append('exec "$@"')
 
@@ -167,7 +183,10 @@ def _lock_impl(ctx):
         inputs = srcs + ctx.files.existing_output,
         mnemonic = "PyRequirementsLockUv",
         outputs = [output],
-        arguments = [args.run_shell],
+        # On Windows, the command line is embedded directly in the .bat
+        # script (with backslash paths). On POSIX, args are forwarded via
+        # exec "$@" in the .sh script.
+        arguments = [args.run_shell] if not ctx.attr.is_windows else [],
         tools = [
             uv,
             python_files,