ibazel failing to restart JS application with heavy external dependencies

[markovejnovic]

Describe the bug

Hey folks! I'm evaluating the use of ibazel with our monorepo and stumbled onto a relatively nasty bug where ibazel would fail to restart my relatively large JS application.

Reproduction instructions

https://github.com/markovejnovic/ibazel-js-repro

git clone https://github.com/markovejnovic/ibazel-js-repro.git
cd ibazel-js-repro
ibazel run //:dev
# wait until it prints 'hello world'
# edit src/main.ts to print a different string
# note ibazel doesn't catch it

Expected behavior

Ibazel restarts my target after a source file changes.

Actual behavior

Ibazel doesn't restart my target.

Version (please complete the following information):

• OS: macOS
• ibazel Version: iBazel - Version 0.29.0, present on HEAD
• Bazel version: 9.1.0

Additional context

I think the bug is in ibazel.go:650. When labelsToWatch filters for labels that should be watched, it has special handling for localRepositories. aspect's external targets start with @ and are referenced as localRepositories, which means that we hit the break in ibazel.go:650.

To be 100% honest, I don't really understand the intent behind this function and this was discovered by getting claude to sprinkle debug statements across the program, so I might be wrong in my guess, but changing the break to a continue does populate the toWatch list as I would expect.

[KarolisL]

I think this relates to #822 since downgrading to v0.28.1 fixes the issue for me.

[dh-seanmurphy]

We have observed this also and came to the same conclusion as @KarolisL - that it relates to #822. However, we didn't get any further than that, ie understanding how it could be fixed.

[KarolisL]

I can add that in our case, the repo is not that big, but we target Linux Golang binaries on macOS, and I suspect that this fact inflates cquery by a lot, compared to just query that was used before the aforementioned PR.

[krupitskas]

+1 here, downgraded ibazel from 29.0 to 28.0, fixed hot reload in my case.

[achew22]

If anyone can produce a reproduction (or get Claude to produce one) I’m happy to merge it and the fix. That’s am that’s holding us back here

[markovejnovic]

Sorry, I've just been crazy busy. I'll do it right now!

[markovejnovic]

By the way, a reproduction was given in this issue:

Reproduction instructions

https://github.com/markovejnovic/ibazel-js-repro

git clone https://github.com/markovejnovic/ibazel-js-repro.git
cd ibazel-js-repro
ibazel run //:dev
# wait until it prints 'hello world'
# edit src/main.ts to print a different string
# note ibazel doesn't catch it

But I'm adding an e2e test into my PR #826, right now

[kirkobyte]

I'm adding JS projects to a pretty large & complex project with a lot of Java & Go, and 0.29.0 is failing for us also. I've not been able to get 0.29.0 to output anything useful to help understand why it's not reloading. I was hoping that using git sparse checkkout to remove most of the repo would help, but unfortunately not

[longlho]

this is already covered in #828 I believe, which is merged and released as 0.30.0