Fetchart file permissions from remote sources do not respect umask

[fxthomas]

Hello all,

I'm wondering how to solve permission issues at import time that have been bugging me for a long time.

I think this can be reproduced by the following steps on a Linux machine:

• Execute beet import . with the fetchart plugin enabled
• Media are moved to the destination directory, in general without issue
• However, the downloaded cover.jpg has very restrictive permissions (typically 600)

This does not happen when cover art is present in the directory I import from, only from remote sources.

I think the main cause of the problem is that beets creates a temporary file to store the contents of the download using tempfile.mkstemp, which has this very restrictive permissions set... and then moves the temporary file in the destination directory, keeping that restrictive permission set. Audio files on the other hand are typically created the regular way with the default umask, and everything is fine for them.

The way downloaded cover art files don't respect the umask is definitely a bit surprising, it took me a while to understand why this happened. Do you feel this something that should be "fixed" at the beets level, and should I create an actual issue ?

Are there better ways to get around that ?

[fxthomas]

A reasonable workaround seems to be avoid moving files but copy them. Setting this configuration:

import:
  move: no

...results in files getting the correct umask and default ACLs in their destination directories. For small import jobs this is probably reasonable.