Scenarios where borg create will/won't report data integrity errors

[chocmake]

Returned to some small scale deliberate segment file corruption testing (using borg v1.4.1 and deleting arbitrary sections in a hex editor) and found that unlike prior tests with corrupted segment files one test didn't cause create to throw an a data integrity error.

However as expected running either prune or check (with --verify-data) reported the issue.

I'm assuming this is normal, that it depends whether create interacts with whatever chunks have integrity issues when doing deduplication or something?

(I'm writing some separate structured logging that I'm feeding to a snapshot visualization, so such testing has been to account for various create/repair/check/etc states)

[ThomasWaldmann]

The only command designed to find errors is borg check (with --verify-data if you really want to check everything cryptographically).

Other commands might stumble over defect/missing segment/chunks or not (if they don't access them).