Skip to content

Commit 2117c4e

Browse files
cursoragentbyte271
andcommitted
Move tactile sounds into Appearance and stop orphaning Feel.
The Feel fieldset used to append after Settings → Advanced once Runtime was no longer a top-level fieldset, which overlapped the lab disclosure. Co-authored-by: Byte271 <byte271@users.noreply.github.com>
1 parent b6a6cc3 commit 2117c4e

2 files changed

Lines changed: 10 additions & 19 deletions

File tree

‎apps/openlive-gateway/web/app.js‎

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2881,25 +2881,11 @@ function wireSetupWizard() {
28812881
}
28822882

28832883
function wireUiSoundToggle() {
2884-
const host = document.querySelector("#settingsPanel .sheet-body");
2885-
if (!host || document.querySelector("#uiSoundToggle")) return;
2886-
const fieldset = document.createElement("fieldset");
2887-
fieldset.className = "sheet-group";
2888-
fieldset.innerHTML = `
2889-
<legend>Feel</legend>
2890-
<label class="checkbox-row" for="uiSoundToggle">
2891-
<input id="uiSoundToggle" type="checkbox" ${isUiSoundMuted() ? "" : "checked"} />
2892-
<span>Tactile sounds (slider ticks, soft clicks)</span>
2893-
</label>
2894-
<p class="setup-hint">Subtle Web Audio feedback — never interrupts voice.</p>
2895-
`;
2896-
// Insert before Runtime if present, else append.
2897-
const runtime = [...host.querySelectorAll("fieldset")].find((f) =>
2898-
f.querySelector("legend")?.textContent?.includes("Runtime"),
2899-
);
2900-
if (runtime) host.insertBefore(fieldset, runtime);
2901-
else host.appendChild(fieldset);
2902-
document.querySelector("#uiSoundToggle")?.addEventListener("change", (event) => {
2884+
const toggle = document.querySelector("#uiSoundToggle");
2885+
if (!toggle || toggle.dataset.bound === "1") return;
2886+
toggle.dataset.bound = "1";
2887+
toggle.checked = !isUiSoundMuted();
2888+
toggle.addEventListener("change", (event) => {
29032889
setUiSoundMuted(!event.target.checked);
29042890
if (event.target.checked) {
29052891
unlockUiAudio();

‎apps/openlive-gateway/web/index.html‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -513,6 +513,11 @@ <h3 class="settings-section-title">
513513
<span class="settings-row-label">Show latency</span>
514514
<input id="latencyToggle" type="checkbox" />
515515
</label>
516+
<label class="settings-row settings-toggle" for="uiSoundToggle">
517+
<span class="settings-row-label">Tactile sounds</span>
518+
<input id="uiSoundToggle" type="checkbox" checked />
519+
</label>
520+
<p class="settings-hint" style="margin:0 12px 10px">Soft clicks for controls — never interrupts voice.</p>
516521
</div>
517522
</section>
518523

0 commit comments

Comments
 (0)