Repository navigation
Commit 58cd701
committed
tests: make xattr test more robust
Currently the xattr test asserts that listxattr() on Cargo.toml returns
a length of 0.
This causes a spurious failure when Cargo.toml does have xattrs, and
this can happen in fairly normal situations like when a Linux
distribution enables selinux (as it does on an AlmaLinux 10 test system,
for example):
$ cat /etc/almalinux-release
AlmaLinux release 10.0 (Purple Lion)
$ getfattr -d -m - Cargo.toml
security.selinux=[...]
$ cargo test --features=fs,stdio xattr
[...]
thread 'xattr::xattr_basic' panicked at tests/fs/xattr.rs:88:5:
assertion `left == right` failed
left: 17
right: 0
This change fixes the failure by making the test not assume that the
file has no xattrs defined.
Given that, pretty much the only reasonable thing the test can assume
about a call to listxattr is that it should succeed for a file that is
known to exist. So this makes the test just assert that it succeeds.1 parent 65b04ae commit 58cd701
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
89 | | - | |
| 88 | + | |
| 89 | + | |
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
| |||
0 commit comments