From 6f9bb2a4be3800fe25df2a0adade328fea21a3ae Mon Sep 17 00:00:00 2001 From: Tobbe Lundberg Date: Thu, 18 Jun 2026 13:07:07 +0200 Subject: [PATCH 1/2] chore(test): Fix locator in dev auth smoke tests --- tasks/smoke-tests/dev/tests/authChecks.spec.ts | 4 ++-- tasks/smoke-tests/dev/tests/rbacChecks.spec.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tasks/smoke-tests/dev/tests/authChecks.spec.ts b/tasks/smoke-tests/dev/tests/authChecks.spec.ts index cf6384f088..0ddcdbf131 100644 --- a/tasks/smoke-tests/dev/tests/authChecks.spec.ts +++ b/tasks/smoke-tests/dev/tests/authChecks.spec.ts @@ -58,11 +58,11 @@ test('requireAuth graphql checks', async ({ page }) => { // Try to create a post as an anonymous user. await createNewPost({ page }) - expect( + await expect( page .locator('.rw-form-error-title') .locator("text=You don't have permission to do that"), - ).toBeTruthy() + ).toBeVisible() await page.goto('/') diff --git a/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts b/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts index d427158446..50e8372ae4 100644 --- a/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts +++ b/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts @@ -63,11 +63,11 @@ test('RBAC: Should not be able to delete contact as non-admin user', async ({ await page.locator('text=Delete').first().click() - expect( + await expect( page .locator('.rw-scaffold') .locator("text=You don't have permission to do that"), - ).toBeTruthy() + ).toBeVisible() // @NOTE we do this because the scaffold content is actually on the page, // This is the only way we validate if its actually showing visually From fdd335d06f140f0420610e56e77ef467d89644bd Mon Sep 17 00:00:00 2001 From: Tobbe Lundberg Date: Thu, 18 Jun 2026 13:49:16 +0200 Subject: [PATCH 2/2] Fix expected text --- tasks/smoke-tests/dev/tests/rbacChecks.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts b/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts index 50e8372ae4..05a7523a8f 100644 --- a/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts +++ b/tasks/smoke-tests/dev/tests/rbacChecks.spec.ts @@ -66,7 +66,7 @@ test('RBAC: Should not be able to delete contact as non-admin user', async ({ await expect( page .locator('.rw-scaffold') - .locator("text=You don't have permission to do that"), + .locator("text=You don't have access to do that"), ).toBeVisible() // @NOTE we do this because the scaffold content is actually on the page,