Skip to content

Commit 02eda24

Browse files
committed
fix: remove unnecessary permissions from documentation workflows
1 parent c239369 commit 02eda24

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎.github/workflows/docs.yml‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,6 @@ jobs:
4242
build:
4343
name: Build documentation
4444
runs-on: ubuntu-latest
45-
permissions:
46-
contents: read
47-
pages: write
4845
steps:
4946
- name: Checkout repository
5047
uses: actions/checkout@v7
@@ -107,10 +104,6 @@ jobs:
107104
if: inputs.deploy_github_pages
108105
needs: build
109106
runs-on: ubuntu-latest
110-
permissions:
111-
contents: read
112-
pages: write
113-
id-token: write
114107
environment:
115108
name: github-pages
116109
url: ${{ steps.deployment.outputs.page_url }}

‎tests/test_docs.py‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ def test_reusable_docs_workflow_supports_artifacts_and_github_pages():
3636
assert "generated_docs_check_task:" in workflow
3737
assert "actions/upload-artifact@v7" in workflow
3838
assert "if-no-files-found: error" in workflow
39+
assert "permissions:" not in workflow
3940
assert "cloudflare" not in workflow.lower()
4041
assert "actions/upload-pages-artifact@v5" in workflow
4142
assert "actions/deploy-pages@v5" in workflow
@@ -51,7 +52,13 @@ def test_repository_uses_reusable_docs_workflow():
5152

5253
assert "uses: ./.github/workflows/docs.yml" in preview_workflow
5354
assert "generated_docs_check_task: check-docs-references" in preview_workflow
55+
assert "contents: read" in preview_workflow
56+
assert "pages: write" not in preview_workflow
57+
assert "id-token: write" not in preview_workflow
5458
assert "uses: ./.github/workflows/docs.yml" in deploy_workflow
5559
assert "deploy_github_pages: true" in deploy_workflow
5660
assert "generated_docs_check_task: check-docs-references" in deploy_workflow
61+
assert "contents: read" in deploy_workflow
62+
assert "pages: write" in deploy_workflow
63+
assert "id-token: write" in deploy_workflow
5764
assert not Path(".github/workflows/docs-preview-cleanup.yml").exists()

0 commit comments

Comments
 (0)