refactor(core): rename JSON-RPC transport APIs with the `JsonRpcTransport` prefix by Hanssen0 · Pull Request #494 · ckb-devrel/ccc

Hanssen0 · 2026-08-19T23:17:07Z

Transport is now JsonRpcTransport
TransportHttp is now JsonRpcTransportHttp
TransportWebSocket is now JsonRpcTransportWebSocket
TransportFallback is now JsonRpcTransportFallback

Not a major change because these APIs haven't been released yet. See #487

I have read the Contributing Guidelines

…port` prefix - `Transport` is now `JsonRpcTransport` - `TransportHttp` is now `JsonRpcTransportHttp` - `TransportWebSocket` is now `JsonRpcTransportWebSocket` - `TransportFallback` is now `JsonRpcTransportFallback`

netlify · 2026-08-19T23:17:12Z

✅ Deploy Preview for appccc ready!

Name	Link
🔨 Latest commit	`0599bc0`
🔍 Latest deploy log	https://app.netlify.com/projects/appccc/deploys/6a8639762e27040008984b81
😎 Deploy Preview	https://deploy-preview-494--appccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 75 (🔴 down 9 from production) Accessibility: 97 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 97 (🟢 up 9 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-08-19T23:17:12Z

✅ Deploy Preview for apiccc ready!

Name	Link
🔨 Latest commit	`0599bc0`
🔍 Latest deploy log	https://app.netlify.com/projects/apiccc/deploys/6a863976f1f2200008650574
😎 Deploy Preview	https://deploy-preview-494--apiccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 85 (🔴 down 6 from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 95 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-08-19T23:17:12Z

✅ Deploy Preview for liveccc ready!

Name	Link
🔨 Latest commit	`0599bc0`
🔍 Latest deploy log	https://app.netlify.com/projects/liveccc/deploys/6a8639768f70c800087bb37a
😎 Deploy Preview	https://deploy-preview-494--liveccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 35 (🔴 down 6 from production) Accessibility: 88 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

changeset-bot · 2026-08-19T23:17:19Z

🦋 Changeset detected

Latest commit: 0599bc0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages

Name	Type
@ckb-ccc/core	Minor
@ckb-ccc/did-ckb	Patch
@ckb-ccc/eip6963	Patch
@ckb-ccc/joy-id	Patch
@ckb-ccc/lumos-patches	Patch
@ckb-ccc/nip07	Patch
@ckb-ccc/okx	Patch
@ckb-ccc/rei	Patch
@ckb-ccc/shell	Patch
@ckb-ccc/spore	Patch
@ckb-ccc/ssri	Patch
@ckb-ccc/type-id	Patch
@ckb-ccc/udt	Patch
@ckb-ccc/uni-sat	Patch
@ckb-ccc/utxo-global	Patch
@ckb-ccc/xverse	Patch
@ckb-ccc/ccc	Patch
@ckb-ccc/app	Patch
ckb-ccc	Patch
@ckb-ccc/connector	Patch
@ckb-ccc/connector-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-08-19T23:17:28Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2a58e3e5-c51f-4ef9-b2cb-280fcd640290

📥 Commits

Reviewing files that changed from the base of the PR and between b5cf384 and 0599bc0.

📒 Files selected for processing (11)

.changeset/wet-beans-arrive.md
packages/core/src/jsonRpc/requestor.test.ts
packages/core/src/jsonRpc/requestor.ts
packages/core/src/jsonRpc/transports/factory.ts
packages/core/src/jsonRpc/transports/fallback.test.ts
packages/core/src/jsonRpc/transports/fallback.ts
packages/core/src/jsonRpc/transports/http.test.ts
packages/core/src/jsonRpc/transports/http.ts
packages/core/src/jsonRpc/transports/transport.ts
packages/core/src/jsonRpc/transports/webSocket.test.ts
packages/core/src/jsonRpc/transports/webSocket.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Summary by CodeRabbit

Breaking Changes
- Renamed JSON-RPC transport APIs with clearer JsonRpcTransport-prefixed names.
- Renamed HTTP, WebSocket, and fallback transport classes accordingly.
- Renamed the URI-based transport factory to reflect its JSON-RPC scope.
- Updated requestor transport configuration and usage to the new API names.
Bug Fixes
- Preserved existing URI protocol selection, timeout handling, fallback behavior, and request processing.
Tests
- Updated transport coverage to validate the renamed APIs without changing tested behavior.

Walkthrough

The JSON-RPC transport interface, implementations, factory, requestor, tests, and changeset now use JsonRpcTransport-prefixed names. Transport behavior remains unchanged.

Changes

JSON-RPC transport API renames

Layer / File(s)	Summary
Transport contracts and implementations `packages/core/src/jsonRpc/transports/transport.ts`, `packages/core/src/jsonRpc/transports/http.ts`, `packages/core/src/jsonRpc/transports/webSocket.ts`, `packages/core/src/jsonRpc/transports/fallback.ts`	Renames the transport interface and concrete classes to `JsonRpcTransport`, `JsonRpcTransportHttp`, `JsonRpcTransportWebSocket`, and `JsonRpcTransportFallback`.
Factory and requestor wiring `packages/core/src/jsonRpc/transports/factory.ts`, `packages/core/src/jsonRpc/requestor.ts`	Renames the URI factory to `jsonRpcTransportFromUri` and updates `RequestorJsonRpc` to use the renamed transport abstractions.
Renamed API validation and release metadata `packages/core/src/jsonRpc//.test.ts`, `packages/core/src/jsonRpc/requestor.test.ts`, `.changeset/wet-beans-arrive.md`	Updates tests and release metadata for the renamed transport API. Existing test behavior remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 0599b

This is a localized rename of unreleased JSON-RPC transport APIs, with no actionable merge-blocking risk remaining after normal checks and review.

Possibly related PRs

ckb-devrel/ccc#448: Overlaps in fallback transport code and tests, but changes concurrent fallback behavior.
ckb-devrel/ccc#452: Overlaps in RequestorJsonRpc and its tests, but changes concurrency error handling.
ckb-devrel/ccc#487: Overlaps in JSON-RPC transport abstractions and RequestorJsonRpc, but adds close and response functionality.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the JSON-RPC transport API renames covered by the pull request.
Description check	✅ Passed	The description lists the renamed APIs, explains the release impact, references the related issue, and includes the required guidelines checkbox.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

netlify · 2026-08-19T23:18:21Z

✅ Deploy Preview for docsccc ready!

Name	Link
🔨 Latest commit	`0599bc0`
🔍 Latest deploy log	https://app.netlify.com/projects/docsccc/deploys/6a8639762e27040008984b83
😎 Deploy Preview	https://deploy-preview-494--docsccc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 78 (🔴 down 10 from production) Accessibility: 95 (no change from production) Best Practices: 92 (🔴 down 8 from production) SEO: 75 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Hanssen0 merged commit f6aafb2 into ckb-devrel:dev Aug 19, 2026
18 checks passed

Hanssen0 deleted the refactor/transport branch August 19, 2026 23:22

github-actions Bot mentioned this pull request Aug 19, 2026

chore(dev): bump packages version #489

Open

Navigation Menu

Uh oh!

refactor(core): rename JSON-RPC transport APIs with the `JsonRpcTransport` prefix - #494

refactor(core): rename JSON-RPC transport APIs with the `JsonRpcTransport` prefix#494
Hanssen0 merged 1 commit into
ckb-devrel:devfrom
Hanssen0:refactor/transport

Hanssen0 commented Aug 19, 2026

Uh oh!

netlify Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Aug 19, 2026

Uh oh!

coderabbitai Bot commented Aug 19, 2026 •

edited

Loading

Reviews paused

Summary by CodeRabbit

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

netlify Bot commented Aug 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Hanssen0 commented Aug 19, 2026

Uh oh!

netlify Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for appccc ready!

Uh oh!

netlify Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for apiccc ready!

Uh oh!

netlify Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for liveccc ready!

Uh oh!

changeset-bot Bot commented Aug 19, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Summary by CodeRabbit

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

netlify Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docsccc ready!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

netlify Bot commented Aug 19, 2026 •

edited

Loading

netlify Bot commented Aug 19, 2026 •

edited

Loading

netlify Bot commented Aug 19, 2026 •

edited

Loading

coderabbitai Bot commented Aug 19, 2026 •

edited

Loading

netlify Bot commented Aug 19, 2026 •

edited

Loading