Repository navigation
Commit 0a826ad
fix: give the report header a logo that survives being small
#259 swapped the old wordmark badge for the org's new mark, which was the
right art but the wrong variant for this surface. The header renders the
image at 20px, and the wordless mark is a stroke on transparency -- at that
size a stroke carries almost no visual weight, so the header read as a faint
tick rather than a mark. It is worst on GitHub's dark theme, where a thin
brand-blue line sits close to the background.
Two things were wrong, not one:
* The variant. branding/logo-mark.png is documented for use "where a
background already exists"; the comment header has none, so the mark had
nothing to sit on. branding/avatar.png is the filled version and the one
the branding README calls out as legible small. Using it here is what the
asset is for.
* The size. The report title is an h2, which GitHub renders at about 24px,
so a 20px icon was smaller than the words beside it and lost the visual
hierarchy before any question of contrast.
So assets/logo.png is now a 128x128 downscale of avatar.png with the corners
rounded (22%), and the width goes 20 -> 24 to match the h2 cap height.
Rounding matters because GitHub rounds avatars in its own UI but not inline
images; without it the header carries a hard blue square.
Measured on the written file: RGBA preserved with the corners genuinely
transparent (alpha 0 at 0,0 -- a flattened export would have shown 255 and
rendered as a white box on dark), and the two dominant opaque colours are
(44,156,205) = #2c9ccd and white, i.e. the brand blue and the check.
4994 -> 2822 bytes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn1 parent 5957b2f commit 0a826ad
3 files changed
Lines changed: 12 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
242 | 242 | | |
243 | 243 | | |
244 | 244 | | |
245 | | - | |
| 245 | + | |
246 | 246 | | |
247 | 247 | | |
248 | 248 | | |
| |||
266 | 266 | | |
267 | 267 | | |
268 | 268 | | |
269 | | - | |
| 269 | + | |
270 | 270 | | |
271 | 271 | | |
272 | 272 | | |
| |||
Loading
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
38 | 45 | | |
39 | 46 | | |
40 | 47 | | |
41 | 48 | | |
42 | 49 | | |
43 | 50 | | |
44 | 51 | | |
45 | | - | |
| 52 | + | |
46 | 53 | | |
47 | 54 | | |
48 | 55 | | |
| |||
567 | 574 | | |
568 | 575 | | |
569 | 576 | | |
570 | | - | |
| 577 | + | |
571 | 578 | | |
572 | 579 | | |
573 | 580 | | |
| |||
592 | 599 | | |
593 | 600 | | |
594 | 601 | | |
595 | | - | |
| 602 | + | |
596 | 603 | | |
597 | 604 | | |
598 | 605 | | |
| |||
0 commit comments