Replace rule on positive score - #656
Open
fhenneke wants to merge 1 commit into
Open
Conversation
and replace it by executing at lest one order eligible for surplus
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. 鈿欙笍 Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns the documentation with the changes implemented in this PR in the autopilot.
Before, every solution with a score of zero was filtered out as invalid. This is problematic for som esolutions where tokens with few decimals are traded. Giving a small amount of surplus in such tokens might not be possible while executing at zero surplus can reasonably be regarded as better than not executing.
With combinatorial auctions and multiple winners, the old argument around a solution with zero score not beating the empty solution is also not valid anymore. The winner selection would pick both in such cases.
To avoid issues with solvers submitting actually emty solutions, we now require valid solutions to propose the execution of at least one order which can contribute to score. This currently includes orders from the orderbook and jit orders created by addresses on the list of surplus capturing jit order owners. It excludes (jit) liquidity orders.