ci: bootstrap PR-first runner image publishing - #4912
infraclaw-dash wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: dashpay/platform/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Final review complete — no blockers (commit 3fac2dd) · triage: low · Phase 2 only (queue backlog) |
thepastaclaw
left a comment
There was a problem hiding this comment.
Final validation — Phase 2 only (queue backlog)
Verified the one-file change at head 3fac2dd: the caller pins an immutable reusable-workflow revision, explicitly passes two registry secrets, and separates candidate cancellation from branch-scoped promotion concurrency. The supplied Phase-2 reviews contain no findings, and source inspection identified no concrete in-scope defect; git diff --check passed. The companion workflow’s isolation and promotion checks were not independently verified from this local repository, actionlint was unavailable, and end-to-end activation remains unverified.
Review provenance
Source: reviewer 1: gpt-6-astra (agent: phase2-reviewer, role: general); reviewer 2: gpt-6-astra (agent: phase2-reviewer, role: architecture-layering); reviewer 3: gpt-6-astra (agent: phase2-reviewer, role: security-auditor); final verifier: gpt-6-astra (agent: astra-verifier, role: final-verifier)
- Triage:
lowbygpt-6-astra(effort low) — The diff adds a small, contained CI caller with explicit event filters, concurrency rules, and an immutable reusable-workflow pin, delegating build and publication logic without changing any qualifying critical surface. - Phase 1 reviewers: not run (skipped for throughput: 28 PRs queued, above the 10 limit)
- Fresh verifier:
gpt-6-astra— final-verifier; agentastra-verifier - Phase 2 reviewers:
gpt-6-astra— general (completed, effort medium); agentphase2-reviewer,gpt-6-astra— architecture-layering (completed, effort medium); agentphase2-reviewer,gpt-6-astra— security-auditor (completed, effort medium); agentphase2-reviewer
|
/self-reviewed |
|
Bots are done — your move: post |
|
/self-reviewed |
|
Policy satisfied — this can merge. |
Issue being fixed or feature implemented
Bootstrap PR-first runner images for #4702. A trusted
pull_request_targetpublisher must already exist on the target branch before it can build an image for an unmerged requirements PR.Companion implementation: dashpay/dash-selfhosted-image#1
What was done?
.github/workflows/runner-image-candidate.yml, pinned to reviewed immutable control revisionbaf8849b900555d66714e0e1fcffdff669b9e404in the companion image repository..github/runner-requirements.jsonis the automatic build flag. Build and publication use different disposable hosted VMs; the credentialed publisher never executes PR image or application code.How Has This Been Tested?
actionlintandgit diff --checkpass for this one-file caller.Activation / ordering
v4.3-dev(and separately on any other branch intended to use it).DOCKERHUB_USERNAME/DOCKERHUB_TOKENsecrets.This bootstrap PR cannot activate itself from an unmerged head. It does not dispatch or publish images for unrelated PRs.
Breaking Changes
None to existing jobs; the caller only handles PRs changing the new requirements manifest. Promotion updates registry channels, not running containers.
Checklist:
PR Hygiene ·
3fac2dd.github/workflows/runner-image-candidate.yml) — approved by shumkovWhen every box is checked the
PR Hygienecheck passes and this can merge.