From 7837eafd2184332b3a8fe076f8dbdb00da5d0326 Mon Sep 17 00:00:00 2001 From: Anna Tao Date: Thu, 28 May 2026 13:51:41 -0700 Subject: [PATCH 1/2] feat: add CLIENT SETNAME for connection identification Adds client_name="haystack_vector_store_client" to all 4 Glide client configurations (sync/async, standalone/cluster) so connections are identifiable via CLIENT LIST on the server. Fixes #3356 Signed-off-by: Anna Tao --- .../document_stores/valkey/document_store.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py b/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py index 2292843fdb..8742ade065 100644 --- a/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py +++ b/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py @@ -224,6 +224,7 @@ def _get_connection(self) -> SyncGlideClient | SyncGlideClusterClient: addresses=addresses, use_tls=self._use_tls, credentials=self._build_credentials(self._username, self._password), + client_name="haystack_vector_store_client", request_timeout=self._request_timeout, reconnect_strategy=reconnect_strategy, ) @@ -233,6 +234,7 @@ def _get_connection(self) -> SyncGlideClient | SyncGlideClusterClient: addresses=addresses, use_tls=self._use_tls, credentials=self._build_credentials(self._username, self._password), + client_name="haystack_vector_store_client", request_timeout=self._request_timeout, reconnect_strategy=reconnect_strategy, ) @@ -261,6 +263,7 @@ async def _get_connection_async(self) -> GlideClient | GlideClusterClient: addresses=addresses, use_tls=self._use_tls, credentials=self._build_credentials(self._username, self._password), + client_name="haystack_vector_store_client", request_timeout=self._request_timeout, reconnect_strategy=reconnect_strategy, ) @@ -270,6 +273,7 @@ async def _get_connection_async(self) -> GlideClient | GlideClusterClient: addresses=addresses, use_tls=self._use_tls, credentials=self._build_credentials(self._username, self._password), + client_name="haystack_vector_store_client", request_timeout=self._request_timeout, reconnect_strategy=reconnect_strategy, ) From fb068a4931a8f67f6f895aa729e301a362cd84f3 Mon Sep 17 00:00:00 2001 From: Anna Tao Date: Tue, 30 Jun 2026 09:49:04 -0700 Subject: [PATCH 2/2] fix: remove duplicate client_name keyword argument Signed-off-by: Anna Tao --- .../document_stores/valkey/document_store.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py b/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py index d763dc4da5..8742ade065 100644 --- a/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py +++ b/integrations/valkey/src/haystack_integrations/document_stores/valkey/document_store.py @@ -237,7 +237,6 @@ def _get_connection(self) -> SyncGlideClient | SyncGlideClusterClient: client_name="haystack_vector_store_client", request_timeout=self._request_timeout, reconnect_strategy=reconnect_strategy, - client_name="haystack_vector_store_client", ) self._client = SyncGlideClient.create(client_config) return self._client @@ -277,7 +276,6 @@ async def _get_connection_async(self) -> GlideClient | GlideClusterClient: client_name="haystack_vector_store_client", request_timeout=self._request_timeout, reconnect_strategy=reconnect_strategy, - client_name="haystack_vector_store_client", ) self._async_client = await GlideClient.create(client_config) return self._async_client