sub_directory not working after 7.4

[Nico-Schaefer-2111]

Deployer Version

=7.4.x

Target OS

Ubuntu

Which PHP version are you using?

PHP 8.4

Content of deploy.php or deploy.yaml

No response

Steps to reproduce

I am deploying shopware 6 project.
Since there are multiple files and directories in the project root, I always used "sub_directory" to deploy only the necessary source code. Until 7.3.x it worked all fine. When I try to update to >= 7.4.x Deployer always deploys the repository root and therefore throws some errors. After downgrade to 7.3.x it works all fine again.
Even with version 8.x it does not work

[antonmedv]

Thanks for the report — this isn't a regression in deploy:update_code itself, it's the Shopware recipe.

Since v7.4.1, recipe/shopware.php replaces the core deploy:update_code task with an rsync upload of your local working directory:

task('deploy:update_code')->setCallback(static function () {
upload('.', '{{release_path}}', [
'options' => ['--exclude=.git', '--exclude=deploy.php', '--exclude=node_modules'],
]);
});

That was added in #3816. Because it never touches git, it ignores sub_directory, and also repository, update_code_strategy, --branch/--tag/--revision, and
it doesn't write the REVISION file. That's why you see the whole repository root in the release. v7.3.x didn't have this override, which is why downgrading
helps.

As a workaround, restore the git-based task in your deploy.php after requiring the recipe:

require 'recipe/shopware.php';
require 'recipe/deploy/update_code.php'; // restores the git-based deploy:update_code
set('sub_directory', 'src');

Note this also removes the before('deploy:update_code', 'sw-build-without-db') hook, so if you rely on the local build-without-database flow you'll need to
re-add it.

We'll look at either removing the override or making it opt-in, since it silently changes the deployment strategy for every Shopware user.