Font replacement not working correctly

[EmberLightVFX]

When I replace a font with another the font gets replaced but the text becomes suuuuuper small

I tried changing the size to 200 but it doesn't change the resolution.

Here is the font:
FrogDetectiveNeat-Latin.zip

This is the files that UGT generates:
fonts.zip

Checking the logs nothing seems wrong: https://pastes.io/WWVuyAlI

but if I restart the game I'm getting this error in the logs:

--- BEGIN IL2CPP STACK TRACE ---
System.NullReferenceException: Object reference not set to an instance of an object.

--- END IL2CPP STACK TRACE ---

   at Il2CppInterop.Runtime.Il2CppException.RaiseExceptionIfNecessary(IntPtr returnedException) in /home/runner/work/Il2CppInterop/Il2CppInterop/Il2CppInterop.Runtime/Il2CppException.cs:line 36
   at UnityEngine.Object.get_name()
   at UnityGameTranslator.Core.FontManager.ApplyFontReplacement(Object component, Object originalFontObj, String originalFontName)
   at UnityGameTranslator.Core.TranslatorPatches.ProcessTextPatchPrefix(Object __instance, String& textValue, String componentType)
[Error  :UnityGameTranslator] [Patches] ProcessTextPatchPrefix error (TMP): System.NullReferenceException: Object reference not set to an instance of an object.

Here is the full log in case you want to see it: https://pastes.io/CBj4CfHR

[djethino]

I take a look ! :)

[djethino]

can you try with this version ?

UnityGameTranslator.zip

[EmberLightVFX]

Just tried it. Before testing I remove the old generated font-files and clear the font-selection from the config file.

When I load the font it ones again becomes very small and changing the size after doesn't affect the font.
Here is the logs for that: https://pastes.io/KnA19Pj4

When I restart the game I no longer get the errors like I did before but I see this:
[Warning:UnityGameTranslator] [FontManager] Failed to load custom font: FrogDetectiveNeat-Latin
and

[Info   :UnityGameTranslator] [CustomFontLoader] Successfully created font asset for FrogDetectiveNeat-Latin
[Warning:UnityGameTranslator] [FontManager] Cannot access fallback list for: FrogDetectiveNeat

The showing font is the original one and not the one I try to replace with.
Here is the full log: https://pastes.io/q8ySqrAE

[djethino]

Thanks a lot for the logs, the compensation was applied on the wrong TMP property and on restart the font asset was created through a path that never told already-visible texts to refresh. I fixed it in this build, could you give it a try?

UnityGameTranslator.zip

[EmberLightVFX]

It seems like I'm getting the same result. The font becomes super small and doesn't change its scale.
After a restart I'm see the original font again and seeing some errors in the logs.
First log: https://pastes.io/dLfabmYl
After restart log: https://pastes.io/rcJh5TCT

[djethino]

Thanks for testing. I tried the same font on other games here (same IL2CPP and TMP Generation) everything works, so something is specific to your game. I added diagnostics to this build to see what. Could you try it with "debug": true added in config.json, load the font, restart once like before, and send both full logs?

UnityGameTranslator.zip

[EmberLightVFX]

I just noticed something... I always go into the settings page as I have the word Språk to see if the å is working in the new font.
But if I stay in the main screen, when I first replace the font I see this result (I tried change to Gothic just to use a system front instead of custom, that that would change something, it didn't):

All text is replaced but when I restart the game it looks like this:

The title screen's text is still replaced! But not the menu text. If I go into UGT's font settings and toggle the replacement on and off the title text ends up being the original but now the menu text is replaced.

My guess is that UGT doesn't replace all instances of text with the new font, just the first or last one.
As this seems to be an edge-case so far and to make things easier, can I gift you the game for you to debug on? I tried email you at contact@asymptomatikgames.com. If that email doesn't go to you, where can I contact you?

[djethino]

Being able to test on the game made all the difference, thanks again! Text size, styling/shadows and the menu after a restart are all fixed, and the Size setting now works on this kind of text. Could you give this build a try? Your generated font files will refresh automatically on first launch.

UnityGameTranslator.zip

[djethino]

I see another problem with the translations in the dialog bubbles, the text disappear after a runtime translation (ok after a restart). I'm investigating, I think the game replay the typewriting after a text change and create a bug.

[EmberLightVFX]

The version you posted here works great! Great work!
Yeah the text disappears but for me it's ok, I go through the English dialogue and then do the translation. But for live-translation of games that could be a problem.

I am seeing two graphical bugs with my font-replacement.
To match the size of the font I have to set the size to 180%
Doing that matches the size but the font is very jagged and not smooth like before.
Any font-effects, like drop-shadows and outlines in my case, gets scaled up too and becomes very big.

[djethino]

on my side I putted 140% and aliasing seems to be okay, can you remove .gen.json and .gen.png files in the fonts folder of the plugin to force the regeneration of the font. (I made some change on the resolution of generated fonts, before it was hardcoded, now it's dynamic and the hardcoded version was low resolution because of CJK alphabets that have a lot of chars)

this more recent test version patch the problem mentioned with the transparent texts but I have some test to do on other games to check if there is some regressions before release a new version. On my side I have not the problem with the shadow, so try with it, may be I corrected something after the last test version I sent to you.

UnityGameTranslator.zip

PS: it's a little more aliased because I can't directly replace fonts by dynamic fonts, it's a generated bitmap with a static size. and as we upscale it at x%, the shadow is bigger too. It's a technical limitation.

[EmberLightVFX]

Removed the old files in the font folder and tried your latest version, I'm still seeing the problem.
You can see it in the title:
Original:

Original but translated (with some font scaling I accidentally left on):

And with the replaced font + scaling:

Easiest to see it is in a dialogue on the characters name.
Original:

Replace front with no scaling:

Replaced font + scaling:

If I measure the shadow and outline on the original and the replaced without scaling they have the same size. With the scaling it becomes bigger. So it feels like the font gets generated with its styling and then gets scaled up. That could also be the reason why you see a more pixelated font in the upscaled version.

[djethino]

okay it's the PS I just added:

PS: it's a little more aliased because I can't directly replace fonts by dynamic fonts, it's a generated bitmap with a static size. and as we upscale it at x%, the shadow is bigger too. It's a technical limitation.

I can't do anything for that :)