Repository navigation
fix: preserve optional dependency state when starting by project - #14421
Closed
huong8373tt-beep wants to merge 1 commit into
Closed
huong8373tt-beep wants to merge 1 commit into
huong8373tt-beep wants to merge 1 commit into
Conversation
Signed-off-by: Slai.life <huong8373tt@gmail.com>
huong8373tt-beep
force-pushed
the
work/compose-14311
branch
from
October 28, 2026 22:43
fdc2031 to
3d79c22
Compare
Author
|
Added the DCO sign-off to the commit and force-pushed the signed commit as |
Contributor
|
duplicates #14312 |
Author
|
Thanks for the pointer. #14312 was closed because maintainers do not want to extend the string-formatted label format for this mode; this PR takes the same rejected direction. I am closing it rather than pursuing a duplicate implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14311.
Compose stores
depends_onmetadata in the container label used to reconstruct a project fordocker compose start -p. The label previously omittedrequired, so reconstructed dependencies always became required. This change stores the flag as a fourth field and restores it, while keeping older three-field labels compatible by defaulting them torequired=true.Regression coverage verifies both the new optional-dependency encoding and legacy-label compatibility.
Slai Agent Runtime assisted with the investigation, implementation, and testing of this contribution. The account owner authorized the submitted changes and is responsible for the submission.