From 818cbdf75b89b611358e5fae63b13a4f88f8269f Mon Sep 17 00:00:00 2001 From: Dax Mobile <44842493+daxmobile@users.noreply.github.com> Date: Sat, 1 Aug 2026 07:09:11 +0100 Subject: [PATCH] Correct the plugin-points section in the architecture rule doc JsInjectorPlugin and ContentScopeJsMessageHandlersPlugin were listed as "notable active plugin points" but both are declared with @ContributesPluginPoint and consumed as PluginPoint. List them as basic plugin points and name the real active ones. Co-Authored-By: Claude Opus 5 (1M context) --- .cursor/rules/architecture.mdc | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/.cursor/rules/architecture.mdc b/.cursor/rules/architecture.mdc index ef4971409fb3..c0862b8eb49d 100644 --- a/.cursor/rules/architecture.mdc +++ b/.cursor/rules/architecture.mdc @@ -271,9 +271,24 @@ class Foo @Inject constructor(private val plugins: ActivePluginPoint) All flags default to `TRUE` so newly contributed plugins are on by default and can be killed remotely. -### Notable active plugin points in the browser -- `JsInjectorPlugin` — hooks into `onPageStarted` / `onPageFinished` on the browser WebView -- `ContentScopeJsMessageHandlersPlugin` — handles JS→native messages via content scope scripts +### Notable plugin points in the browser + +Basic (`@ContributesPluginPoint`, consumed as `PluginPoint`, no feature-flag gating): + +| Plugin | Point declared by | Purpose | +|---|---|---| +| `JsInjectorPlugin` | `UnusedJsInjectorPluginPoint` (`:app`) | hooks into `onPageStarted` / `onPageFinished` on the browser WebView | +| `ContentScopeJsMessageHandlersPlugin` | `ContentScopeJsMessageHandlersPluginPoint` (`content-scope-scripts-impl`) | handles JS→native messages via content scope scripts | + +Active (`@ContributesActivePluginPoint`, consumed as `ActivePluginPoint`, flag-gated): + +| Plugin | Plugin point `featureName` | +|---|---| +| `NewTabPagePlugin` | `pluginPointNewTabPagePlugin` | +| `NewTabPageSectionPlugin` | `pluginPointNewTabPageSectionPlugin` | +| `NewTabPageShortcutPlugin` | `pluginPointNewTabPageShortcutPlugin` | +| `NativeInputPlugin` | `pluginPointNativeInput` | +| `NativeInputChatTabItemPlugin` | `pluginPointNativeInputChatTabItemPlugin` | ---