Repository navigation
Commit de7675c
Clean up stopped test threads under ASAN
Summary:
AddressSanitizer can retain stopped TestThread objects after their OS threads have joined. This leaves those objects in threading._dangling and makes regrtest report ENV CHANGED even though all threading tests pass.
After joining every test thread and asserting that it has stopped, remove these test-owned objects from the private diagnostic weak set on ASAN builds. Normal builds retain the existing dangling-thread leak detection.
Keep the replayable 3.14 patch and its metadata synchronized with the patched tree.
Reviewed By: yoney
Differential Revision: D122693875
fbshipit-source-id: 9020eaac9da67d7625193dcde3f1feef81cff31e1 parent 97e7f5a commit de7675c
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
234 | 237 | | |
235 | 238 | | |
236 | 239 | | |
| |||
0 commit comments