From 570321729bf435c5e8dd2853f3f5ae923f92fab6 Mon Sep 17 00:00:00 2001 From: Peter Kruse Date: Fri, 22 May 2026 16:24:57 +0200 Subject: [PATCH 1/2] [shaman] Elemental, enable all Flame Shocks to call Ancestors using Routine Communication Ingame casting only Ascendance and/or Voltaic Blaze allows to summon multiple Ancestors at once. This indicated that each FS application to a target counts as a trigger. --- engine/class_modules/sc_shaman.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/engine/class_modules/sc_shaman.cpp b/engine/class_modules/sc_shaman.cpp index 034571da480..0e7e001697d 100644 --- a/engine/class_modules/sc_shaman.cpp +++ b/engine/class_modules/sc_shaman.cpp @@ -8229,12 +8229,9 @@ struct flame_shock_t : public shaman_spell_t void execute() override { shaman_spell_t::execute(); - if ( is_variant( spell_variant::NORMAL ) ) + if ( p()->talent.routine_communication.ok() && p()->rng_obj.routine_communication->trigger() ) { - if ( p()->talent.routine_communication.ok() && p()->rng_obj.routine_communication->trigger() ) - { - p()->summon_ancestor(); - } + p()->summon_ancestor(); } } }; From 4d42483df0546b574e30cea0de3439afc89445c3 Mon Sep 17 00:00:00 2001 From: Peter Kruse Date: Fri, 22 May 2026 17:47:34 +0200 Subject: [PATCH 2/2] [shaman] Elemental ancestors cast when spells hit the target --- engine/class_modules/sc_shaman.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/engine/class_modules/sc_shaman.cpp b/engine/class_modules/sc_shaman.cpp index 0e7e001697d..bc4a89cd80e 100644 --- a/engine/class_modules/sc_shaman.cpp +++ b/engine/class_modules/sc_shaman.cpp @@ -3107,7 +3107,12 @@ struct shaman_spell_base_t : public shaman_action_t this->p()->gain.aftershock ); this->p()->proc.aftershock->occur(); } - + } + + void impact( action_state_t* s ) override + { + ab::impact( s ); + if ( ( this->execute_state->action->id == 188389 ) || ( this->is_variant( spell_variant::NORMAL ) && !this->background) ) {