Skip to content

Commit aa3080a

Browse files
committed
style: update comments to include xxl
1 parent 6eece13 commit aa3080a

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

‎core/src/components/grid/test/fixed/grid.e2e.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,9 @@ const minWidthFor = (bp: (typeof ION_GRID_BREAKPOINTS)[number]): number => {
1919

2020
/**
2121
* Viewport width that activates each breakpoint. `max(400, minWidth)` lands
22-
* exactly on the threshold for sm/md/lg/xl (firing only that breakpoint's
23-
* rule and nothing above it) while giving xs a renderable non-zero viewport.
22+
* exactly on the threshold for every breakpoint above xs (firing only that
23+
* breakpoint's rule and nothing above it) while giving xs a renderable non-zero
24+
* viewport.
2425
*/
2526
const VIEWPORT_AT_BREAKPOINT = Object.fromEntries(
2627
ION_GRID_BREAKPOINTS.map((bp) => [bp, Math.max(400, minWidthFor(bp))])

‎core/src/themes/mixins.scss‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -137,15 +137,15 @@
137137
//
138138
// Breakpoints are defined as a map of (name: minimum width), order from small to large:
139139
//
140-
// (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px)
140+
// (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px, xxl: 1400px)
141141
//
142142
// The map defined in the `$screen-breakpoints` global variable is used as the `$breakpoints` argument by default.
143143

144144
// ---------------------------------------------------------------------------------
145145

146146
// Minimum breakpoint width. Null for the smallest (first) breakpoint.
147147
//
148-
// >> breakpoint-min(sm, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px))
148+
// >> breakpoint-min(sm, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px, xxl: 1400px))
149149
// 576px
150150
@function breakpoint-min($name, $breakpoints: $screen-breakpoints) {
151151
$min: map-get($breakpoints, $name);
@@ -156,9 +156,9 @@
156156
// Returns a blank string if smallest breakpoint, otherwise returns the name with a dash infront.
157157
// Useful for making responsive utilities.
158158
//
159-
// >> breakpoint-infix(xs, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px))
159+
// >> breakpoint-infix(xs, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px, xxl: 1400px))
160160
// "" (Returns a blank string)
161-
// >> breakpoint-infix(sm, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px))
161+
// >> breakpoint-infix(sm, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px, xxl: 1400px))
162162
// "-sm"
163163
@function breakpoint-infix($name, $breakpoints: $screen-breakpoints) {
164164
@return if(breakpoint-min($name, $breakpoints) == null, "", "-#{$name}");
@@ -182,9 +182,9 @@
182182
//
183183
// >> breakpoint-next(sm)
184184
// md
185-
// >> breakpoint-next(sm, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px))
185+
// >> breakpoint-next(sm, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px, xxl: 1400px))
186186
// md
187-
// >> breakpoint-next(sm, $breakpoint-names: (xs sm md lg xl))
187+
// >> breakpoint-next(sm, $breakpoint-names: (xs sm md lg xl xxl))
188188
// md
189189
@function breakpoint-next($name, $breakpoints: $screen-breakpoints, $breakpoint-names: map-keys($breakpoints)) {
190190
$n: index($breakpoint-names, $name);
@@ -200,7 +200,7 @@
200200
// Uses 0.02px rather than 0.01px to work around a current rounding bug in Safari. // Uses 0.02px rather than 0.01px to work around a current rounding bug in Safari.
201201
// See https://bugs.webkit.org/show_bug.cgi?id=178261 // See https://bugs.webkit.org/show_bug.cgi?id=178261
202202
//
203-
// >> breakpoint-max(md, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px))
203+
// >> breakpoint-max(md, (xs: 0, sm: 576px, md: 768px, lg: 992px, xl: 1200px, xxl: 1400px))
204204
// 767.98px
205205
@function breakpoint-max($name, $breakpoints: $screen-breakpoints) {
206206
$max: map-get($breakpoints, $name);

0 commit comments

Comments
 (0)