chore(git): sync with main (#31509)

Sync feature-9.1 with main.

Author: ShaneK

.github/workflows/codeql-analysis.yml

@@ -15,7 +15,7 @@ jobs:
       security-events: write
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
-      - uses: github/codeql-action/init@b96794f015dfd88f77b49b1c93e0fa7110f94c63 # v4.38.0
+      - uses: github/codeql-action/init@2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2 # v4.38.2
         with:
           languages: javascript
-      - uses: github/codeql-action/analyze@b96794f015dfd88f77b49b1c93e0fa7110f94c63 # v4.38.0
+      - uses: github/codeql-action/analyze@2892aa5e19bbd11bc0cff5427e3b750a04d9e3c2 # v4.38.2

.github/workflows/release.yml

@@ -85,9 +85,17 @@ jobs:
     # possible for them to push at the same time.
     needs: [finalize-release]
     runs-on: ubuntu-latest
+    # This is a backstop for the retry loop in
+    # Resolve Package Locks, which fails with its
+    # own message first.
+    timeout-minutes: 30
     permissions:
       contents: write
       id-token: write
+    outputs:
+      # This says the new versions resolved on npm,
+      # which is not the same as the job passing.
+      resolved: ${{ steps.resolve.outputs.resolved }}
     steps:
       - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
         # Pull the latest version of the reference
@@ -108,25 +116,74 @@ jobs:
           git config user.email hi@ionicframework.com
         shell: bash
       # Lerna does not automatically bump versions
-      # of Ionic dependencies that have changed,
-      # so we do that here.
-      - name: Bump Package Lock
+      # of Ionic dependencies that have changed, so
+      # we do that here. The install fails with
+      # ETARGET until the versions published earlier
+      # resolve on npm, so retry. The
+      # `--prefer-online` flag matters because npm
+      # caches the failed lookup, and an `npm view`
+      # probe would read a different cached document.
+      - name: Resolve Package Locks
+        id: resolve
+        env:
+          SLEEP_SECONDS: 15
+          DEADLINE_SECONDS: 900
+        run: |
+          set -euo pipefail
+          # We bound this on the wall clock so the loop reports its own
+          # error before `timeout-minutes` kills the job. The `timeout`
+          # call caps an attempt that hangs rather than fails, which would
+          # never reach the check below.
+          deadline=$(( SECONDS + DEADLINE_SECONDS ))
+          attempt=0
+          until timeout --kill-after=30 300 lerna exec "npm install --package-lock-only --prefer-online"; do
+            attempt=$(( attempt + 1 ))
+            if [ "$SECONDS" -ge "$deadline" ]; then
+              echo "::error::npm install --package-lock-only failed $attempt times over ${SECONDS}s; see the last attempt above for the error"
+              exit 1
+            fi
+            echo "Attempt $attempt failed, retrying in ${SLEEP_SECONDS}s"
+            sleep "$SLEEP_SECONDS"
+          done
+          echo "resolved=true" >> "$GITHUB_OUTPUT"
+        shell: bash
+      # This is split from the retry so `resolved`
+      # does not depend on the commit and the push
+      # working.
+      - name: Commit Package Locks
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          lerna exec "npm install --package-lock-only"
+          set -euo pipefail
           git add .
+          # Re-running this job after the locks were already committed
+          # would otherwise fail on an empty commit.
+          if git diff --cached --quiet; then
+            echo "No package lock changes to commit"
+            exit 0
+          fi
           git commit -m "chore(): update package lock files"
           git push
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         shell: bash
 
   purge-cdn-cache:
-    needs: [release-ionic]
+    # This runs after `update-package-lock` so the
+    # new versions have resolved on npm. Purging
+    # earlier re-caches `@ionic/core@latest` at the
+    # previous release. A failed `finalize-release`
+    # skips this too, so a half-finished release
+    # that did reach npm needs a manual purge.
+    needs: [update-package-lock]
+    if: ${{ !cancelled() && needs.update-package-lock.outputs.resolved == 'true' }}
     runs-on: ubuntu-latest
+    timeout-minutes: 5
     steps:
       - name: Purge JSDelivr Cache
         run: |
-          curl -X POST \
+          set -euo pipefail
+          if ! response=$(curl -sS --max-time 60 --retry 3 --retry-all-errors \
+            --retry-max-time 120 \
+            -w '\n%{http_code}' -X POST \
             https://purge.jsdelivr.net/ \
             -H 'cache-control: no-cache' \
             -H 'content-type: application/json' \
@@ -142,7 +199,21 @@ jobs:
             "/npm/@ionic/core@7/css/ionic.bundle.css",
             "/npm/@ionic/core@8/css/ionic.bundle.css",
             "/npm/@ionic/core@9/css/ionic.bundle.css",
-            "/npm/@ionic/core@latest/css/ionic.bundle.css"
+            "/npm/@ionic/core@latest/css/ionic.bundle.css",
             "/npm/@ionic/core@next/css/ionic.bundle.css"
-          ]}'
+          ]}'); then
+            echo "::warning::jsDelivr purge request failed"
+            exit 0
+          fi
+          status=${response##*$'\n'}
+          echo "${response%$'\n'*}"
+          # `curl` exits 0 whatever jsDelivr answers, so check the status.
+          # A 4xx means we sent a bad payload, which is otherwise silent.
+          # Anything else is jsDelivr being down, which should not fail
+          # a release.
+          case "$status" in
+            2*) ;;
+            4*) echo "::error::jsDelivr rejected the purge with HTTP $status"; exit 1 ;;
+            *) echo "::warning::jsDelivr purge did not complete (HTTP $status)" ;;
+          esac
         shell: bash

CHANGELOG.md

@@ -1,5 +1,5 @@
 # Get Playwright
-FROM mcr.microsoft.com/playwright:v1.62.1
+FROM mcr.microsoft.com/playwright:v1.63.0
 
 # Set the working directory
 WORKDIR /ionic

core/CHANGELOG.md

@@ -1,6 +1,6 @@
 {
   "name": "@ionic/core",
-  "version": "9.0.3",
+  "version": "9.0.6",
   "description": "Base components for Ionic",
   "engines": {
     "node": ">= 16"
@@ -80,7 +80,7 @@
     "@eslint/js": "^9.0.0",
     "@ionic/eslint-config": "^0.3.0",
     "@ionic/prettier-config": "^2.0.0",
-    "@playwright/test": "^1.62.1",
+    "@playwright/test": "^1.63.0",
     "@rollup/plugin-node-resolve": "^8.4.0",
     "@rollup/plugin-virtual": "^2.0.3",
     "@stencil/angular-output-target": "^1.4.1",
@@ -102,7 +102,7 @@
     "fs-extra": "^9.0.1",
     "jest": "^29.7.0",
     "jest-cli": "^29.7.0",
-    "playwright-core": "^1.62.1",
+    "playwright-core": "^1.63.0",
     "prettier": "^2.6.1",
     "rollup": "^2.26.4",
     "sass": "^1.33.0",

core/Dockerfile

@@ -867,7 +867,7 @@ export namespace Components {
          */
         "getScrollElement": () => Promise<HTMLElement>;
         /**
-          * Recalculate content dimensions. Called by overlays (e.g., popover) when sibling elements like headers or footers have finished rendering and their heights are available, ensuring accurate offset-top calculations.
+          * Recalculates the content dimensions and whether it should size itself to its content. Called by overlays when something they own changes, such as a header finishing its render or `--height` being updated.
          */
         "recalculateDimensions": () => Promise<void>;
         /**