[quality] Add unit tests for scanner-refactor extracted modules (tracks PRs #21518-#21522)

[clubanderson]

Finding

Scanner refactor PRs #21518, #21519, #21520, #21522 (all currently open with needs-tests label) split ~15 oversized files into ~40 new modules. Many of the newly-extracted modules are pure functions or thin hooks with clear input/output contracts — they are ideal unit-test targets but no tests were added alongside the refactor.

The repo already has a working vitest setup with a clean pattern under web/src/lib/__tests__/ (see cn.test.ts, gpu.test.ts, tips.test.ts, icons.test.ts, statusColors.test.ts) and hook-testing pattern in web/src/hooks/useCachedGrpc.test.ts.

Without tests, these refactors carry regression risk because the refactor mechanically moves logic across file boundaries with no behavioral safety net.

Recommendation

Add unit tests for the following high-value extracted modules as follow-up PRs once the parent refactor lands. Priority ordered:

P0 — pure functions with threshold/branch logic (highest regression risk)

• web/src/hooks/useTokenUsage.math.ts — getTokenAlertLevel, reconcileUsageBreakdown, getUsagePeriodKey, getNextResetDate (from [scanner] refactor: split oversized hooks & lib-layer files #21520)
• web/src/components/dashboard/StatBlockValidation.ts — createStatBlockId, getSmartDefault, validateStatAssistResult, validateStatBlockResult (from [scanner] refactor: split oversized dashboard & mission-control components #21522)
• web/src/lib/missions/preflightCheck.checks.ts — each check function (from [scanner] refactor: split oversized hooks & lib-layer files #21520)

P1 — pure data helpers

• web/src/lib/utils/dateFormatting.ts (from [scanner] refactor: split GPU & cluster components #21518)
• web/src/hooks/useStackDiscovery.filters.ts (from [scanner] refactor: split oversized hooks & lib-layer files #21520)
• web/src/components/drilldown/views/MultiClusterSummaryDrillDown/utilities.ts (from [scanner] refactor: split oversized dashboard & mission-control components #21522)

P2 — hooks (renderHook pattern)

• web/src/components/clusters/hooks/useClusterSorting.ts
• web/src/components/clusters/hooks/useGPUDetailData.ts
• web/src/components/clusters/hooks/useNamespaceResourcesData.ts
• web/src/hooks/useGPUReservationsData.ts
• web/src/components/cards/rss/useRSSRefresh.ts

P3 — smoke tests for structural moves

• Import-resolution smoke tests for the new ArgoAppDrillDown/ and MultiClusterSummaryDrillDown/ index barrel files (guards against broken re-exports after the directory move in [scanner] refactor: split oversized dashboard & mission-control components #21522)

Per-PR guidance has also been posted as review comments on each refactor PR.

Priority

• Impact: medium (regression protection for a large refactor; long-term coverage improvement)
• Effort: medium (~40-60 test cases across ~10 files; each file is a self-contained scope)

---

Filed by quality agent (ACMM L4/L6 — full mode)

[github-actions]

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

[clubanderson]

Adding a new item to this tracker:

P0 — pure functions with branch logic (highest regression risk)

• web/src/components/drilldown/views/cluster-drilldown/derivedData.ts — 12 pure functions extracted in PR 🌱 refactor: split ClusterDrillDown into cluster-drilldown subcomponents #21527 (buildClusterLookupNames, filterClusterGPUNodes, filterClusterDeploymentIssues, buildNamespacesFromIssues, buildGpuByType, filterNodesForLens, buildFilteredNamespaceStats, filterDeployments/Services/PVCsForLens, buildNamespaceResources, computeIssueCounts, sumGpuTotals). ~50-60 targeted unit tests recommended. Detailed test plan in PR 🌱 refactor: split ClusterDrillDown into cluster-drilldown subcomponents #21527 comment.

(Not from a scanner branch — human refactor by @Utkarsh-Singhal-26 — but same test-gap pattern.)

[vansh2408]

Hey, I want to take this one

[clubanderson]

Test-infra improvement in flight — PR #21552

@vansh2408 has opened #21552 which adds a Playwright visual regression test at web/e2e/visual/app-navbar-search-visual.spec.ts guarding the SearchResultsPanel category icons — root-causes the CI failure that PRs #21517/#21523 tried to patch at the type-signature level. The scanner PRs would have shipped an emoji visual regression; #21552 restores the lucide icons and pins the behavior with the new visual test.

Also noted in #21552's reviewer notes: two dead-code files still remain from #21513:

• web/src/components/layout/navbar/missions/AIUtils.parts.tsx
• web/src/components/layout/navbar/missions/ValidationAndHandlers.parts.tsx

They compile cleanly but are unreferenced — worth a follow-up cleanup PR.

[clubanderson]

📊 Quality agent status check (2026-07-27)

Confirming the on-main state of each P0 target so @vansh2408 (who claimed this on 2026-07-25) has a clear runway:

P0 target	Parent PR	On main?
web/src/hooks/useTokenUsage.math.ts	#21520	❌ not yet (PR open, mergeable_state: blocked)
web/src/components/dashboard/StatBlockValidation.ts	#21522	❌ not yet
web/src/lib/missions/preflightCheck.checks.ts	#21520	❌ not yet
web/src/lib/utils/dateFormatting.ts	#21518	❌ not yet
web/src/components/drilldown/views/cluster-drilldown/derivedData.ts	#21527	❌ not yet (fork branch, blocked)

Recommendation for @vansh2408: wait for at least one of #21518/#21520/#21522/#21527 to merge before opening a test PR, since the target paths don't exist on main yet. If you want to start now, either:

• rebase your test branch on top of scanner/fix-21499 (for [scanner] refactor: split oversized hooks & lib-layer files #21520 targets) and open the test PR against that branch, or
• start with test infra improvement (🐛 fix(web): restore lucide icons in SearchResultsPanel and drop dead AgentStatusIndicator.parts #21552 pattern) that is orthogonal to the extraction.

Bead recorded for tracking. Not opening a duplicating PR while you own this — ping if you'd like a hand-off.

---

Filed by quality agent (ACMM L4/L6 — full mode)

[clubanderson]

Filed PR #21588 covering P0 item #1 — direct unit tests for web/src/hooks/useTokenUsage.math.ts (37 assertions across getTokenAlertLevel, reconcileUsageBreakdown, getUsagePeriodKey, getNextResetDate, plus the module's exported constants).

The PR is stacked on scanner/fix-21499 (base of #21520) because the target file only exists on that branch; GitHub will auto-retarget to main on merge.

Remaining checklist items (P0 #2 StatBlockValidation, P0 #3 preflightCheck.checks, and P1/P2/P3) still open — will pick these up in follow-up PRs stacked on their respective parent refactors.

---

quality agent (ACMM L4/L6 — full mode)

[clubanderson]

Tracking established. This issue documents the test coverage gaps from the scanner refactor PRs (#21518–#21522) with clear P0/P1/P2/P3 prioritization.

This is a help-wanted task appropriate for contributors to pick up. The guidance is clear — tests should be added once parent refactors land, following the existing vitest patterns under web/src/lib/__tests__/ and web/src/hooks/__tests__/.

No blocking code change needed; this is a testing task for the team to execute as follow-up work.