From dae24e369d19adaaa68f3cf1e8ea3fa502aace4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1s=20Gr=C3=BCner?= <47506558+MegaRedHand@users.noreply.github.com> Date: Mon, 20 Apr 2026 17:08:40 -0300 Subject: [PATCH] chore: bump leanSpec and un-skip tests --- Makefile | 4 ++-- .../blockchain/tests/forkchoice_spectests.rs | 19 ++----------------- 2 files changed, 4 insertions(+), 19 deletions(-) diff --git a/Makefile b/Makefile index 59b072c..c9c1c17 100644 --- a/Makefile +++ b/Makefile @@ -24,8 +24,8 @@ docker-build: ## 🐳 Build the Docker image -t ghcr.io/lambdaclass/ethlambda:$(DOCKER_TAG) . @echo -# 2026-04-16 -LEAN_SPEC_COMMIT_HASH:=e9ddede89f87a46da585bcbce6b5080fad08d5de +# 2026-04-20 +LEAN_SPEC_COMMIT_HASH:=bc17f7ae8d16caec276f4d304e04fd3c65e6de3c leanSpec: git clone https://github.com/leanEthereum/leanSpec.git --single-branch diff --git a/crates/blockchain/tests/forkchoice_spectests.rs b/crates/blockchain/tests/forkchoice_spectests.rs index 38cc1ff..ef38ca9 100644 --- a/crates/blockchain/tests/forkchoice_spectests.rs +++ b/crates/blockchain/tests/forkchoice_spectests.rs @@ -21,23 +21,8 @@ const SUPPORTED_FIXTURE_FORMAT: &str = "fork_choice_test"; mod common; mod types; -// We don't check signatures in spec-tests, so invalid signature tests always pass. -// The gossipAggregatedAttestation/attestation tests fail because the harness inserts -// individual gossip attestations into known payloads (should be no-op) and aggregated -// attestations with validator_id=0 into known (should use proof.participants into new). -// The last three skips are fixtures whose attestation checks require the harness to -// route `gossipAggregatedAttestation` steps through the real aggregated path (see the -// follow-up PR). They're unblocked there. -// TODO: fix these -const SKIP_TESTS: &[&str] = &[ - "test_gossip_attestation_with_invalid_signature", - "test_block_builder_fixed_point_advances_justification", - "test_equivocating_proposer_with_split_attestations", - "test_finalization_prunes_stale_aggregated_payloads", - "test_safe_target_uses_merged_pools_at_interval_3", - "test_tick_interval_0_skips_acceptance_when_not_proposer", - "test_tick_interval_progression_through_full_slot", -]; +/// List of skipped tests +const SKIP_TESTS: &[&str] = &[]; fn run(path: &Path) -> datatest_stable::Result<()> { if let Some(stem) = path.file_stem().and_then(|s| s.to_str())