Is there an existing issue for this?
What happened?
As shown in mozilla/addons-server#25248, async scanners listening to the on_version_created event (or any "blocking auto-approval" event) will prevent run_action() from being executed. That's because we check for the absence/presence of an auto-approval summary, but since async scanners can take some time to return their results, the is_waiting_on_scanners boolean field might be true for some time, and at this point, a summary necessarily exists.
What did you expect to happen?
We should fix that, even though we aren't affected yet.
┆Issue is synchronized with this Jira Task
Is there an existing issue for this?
What happened?
As shown in mozilla/addons-server#25248, async scanners listening to the
on_version_createdevent (or any "blocking auto-approval" event) will preventrun_action()from being executed. That's because we check for the absence/presence of an auto-approval summary, but since async scanners can take some time to return their results, theis_waiting_on_scannersboolean field might be true for some time, and at this point, a summary necessarily exists.What did you expect to happen?
We should fix that, even though we aren't affected yet.
┆Issue is synchronized with this Jira Task