Move the Phabricator patch action types into actions.phabricator (#7039)

Author: RizgarOzan

libs/hackbot-runtime/hackbot_runtime/actions/phabricator.py

@@ -21,10 +21,13 @@
 
 from hackbot_runtime.actions.recorder import ActionsRecorder, confirmation
 
+SUBMIT_PATCH_ACTION_TYPE = "phabricator.submit_patch"
+UPDATE_PATCH_ACTION_TYPE = "phabricator.update_patch"
+
 # Both patch actions submit the working directory's changes as a diff, so
 # anything gated on "this run submits a patch" — today the diff artifact built
 # in ``context.publish_changes`` — has to cover both types.
-PATCH_ACTION_TYPES = frozenset({"phabricator.submit_patch", "phabricator.update_patch"})
+PATCH_ACTION_TYPES = frozenset({SUBMIT_PATCH_ACTION_TYPE, UPDATE_PATCH_ACTION_TYPE})
 
 _PHABRICATOR_TEST_PLAN_HEADER_RE = re.compile(
     r"^(?:Test Plan|Testplan|Tested|Tests):",
@@ -126,7 +129,7 @@ async def submit_patch(
     if parent_revision_id is not None:
         params["parent_revision_id"] = parent_revision_id
     action = recorder.record(
-        "phabricator.submit_patch", params, reasoning=reasoning, ref=ref
+        SUBMIT_PATCH_ACTION_TYPE, params, reasoning=reasoning, ref=ref
     )
     return confirmation(action)
 
@@ -164,7 +167,7 @@ async def update_patch(
     association exactly as they are.
     """
     action = recorder.record(
-        "phabricator.update_patch",
+        UPDATE_PATCH_ACTION_TYPE,
         {"revision_id": revision_id},
         reasoning=reasoning,
     )

libs/hackbot-runtime/hackbot_runtime/context.py

@@ -25,7 +25,10 @@
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 from hackbot_runtime import artifacts, changes
-from hackbot_runtime.actions.phabricator import PATCH_ACTION_TYPES
+from hackbot_runtime.actions.phabricator import (
+    PATCH_ACTION_TYPES,
+    SUBMIT_PATCH_ACTION_TYPE,
+)
 from hackbot_runtime.actions.recorder import ActionsRecorder
 from hackbot_runtime.actions.try_server import TRY_ACTION_TYPES, TRY_PUSH_ACTION_TYPE
 from hackbot_runtime.config import HackbotConfig, load_config
@@ -38,8 +41,6 @@
 
 log = logging.getLogger("hackbot_runtime.context")
 
-_SUBMIT_PATCH_ACTION_TYPE = "phabricator.submit_patch"
-
 
 def _default_run_id() -> str:
     """A unique, sortable id for runs that don't get one from the platform.
@@ -54,7 +55,7 @@ def _default_run_id() -> str:
 
 def _wip_commit_message(actions: list[dict]) -> str:
     """The patch title, else the try push title, for the agent's uncommitted work."""
-    for action_type in (_SUBMIT_PATCH_ACTION_TYPE, TRY_PUSH_ACTION_TYPE):
+    for action_type in (SUBMIT_PATCH_ACTION_TYPE, TRY_PUSH_ACTION_TYPE):
         for action in actions:
             if action["type"] == action_type and action["params"]["title"]:
                 return action["params"]["title"]